fix: prefer classic readme if npm picks up a different filename#130
Merged
danielroe merged 6 commits intonpmx-dev:mainfrom Jan 26, 2026
Merged
fix: prefer classic readme if npm picks up a different filename#130danielroe merged 6 commits intonpmx-dev:mainfrom
danielroe merged 6 commits intonpmx-dev:mainfrom
Conversation
And is not the standard filenames
|
@jonathanyeong is attempting to deploy a commit to the danielroe Team on Vercel. A member of the Team first needs to authorize it. |
jonathanyeong
commented
Jan 26, 2026
| return false | ||
| } | ||
|
|
||
| const filenames = [ |
Contributor
Author
There was a problem hiding this comment.
@danielroe if this approach makes sense, I can extract this out into a shared const since it's duplicated in fetchReadmeFromJsdelivr
danielroe
reviewed
Jan 26, 2026
jonathanyeong
changed the title
jonathanyeong
changed the title
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
danielroe
approved these changes
Jan 26, 2026
Member
danielroe
left a comment
danielroe
left a comment
There was a problem hiding this comment.
(made a few small tweaks - hope that was ok!)
thank you for this ❤️
danielroe
changed the title
Contributor
Author
|
Of course! Thank you for making the PR better! |
vinnymac
pushed a commit
to vinnymac/npmx.dev
that referenced
this pull request
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #117
Why
When fetching from registry npmjs, the incorrect readme filename is returned:
Doing some digging it might be because biomejs stores all its readmes in a single folder. Someone had a similar issue here.
Changes made
Testing
Visiting preview link of biomejs shows english README by default (https://npmxdev-git-fork-jonathanyeong-jy-fix-incorrect-readme-poetry.vercel.app/@biomejs/biome)