Skip to content

fix: prefer classic readme if npm picks up a different filename #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 6 commits into from
Jan 26, 2026
Merged

fix: prefer classic readme if npm picks up a different filename #130

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
514d7af
fix: fetch readme if filename doesn't match locale
jonathanyeong Jan 26, 2026
de5132f
Use readme based on your locale
jonathanyeong Jan 26, 2026
406ed68
refactor filenames const to a shared location and rename method
jonathanyeong Jan 26, 2026
81a37f9
remove locale since it won't exist on the server
jonathanyeong Jan 26, 2026
40eed21
Merge branch 'main' into jy/fix-incorrect-readme
jonathanyeong Jan 26, 2026
0909eb1
refactor: use regexp, hoist filenames, and fall back to npm readme if…
danielroe Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion server/api/registry/readme/[...pkg].get.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,11 @@ export default defineCachedEventHandler(
}

// If no README in packument, try fetching from jsdelivr (package tarball)
if (!readmeContent || readmeContent === NPM_MISSING_README_SENTINEL) {
if (
!readmeContent ||
readmeContent === NPM_MISSING_README_SENTINEL ||
!readmeFilenameMatchesLocale(packageData.readmeFilename)
) {
readmeContent = (await fetchReadmeFromJsdelivr(packageName, version)) ?? undefined
}

Expand Down Expand Up @@ -108,3 +112,21 @@ export default defineCachedEventHandler(
},
},
)

function readmeFilenameMatchesLocale(filename: string | undefined): boolean {
if (!filename) {
return false
}

const filenames = [
Copy link
Copy Markdown
Contributor Author

@jonathanyeong jonathanyeong Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielroe if this approach makes sense, I can extract this out into a shared const since it's duplicated in fetchReadmeFromJsdelivr

'README.md',
'readme.md',
'Readme.md',
'README',
'readme',
'README.markdown',
'readme.markdown',
]

return filenames.includes(filename) || filename.includes(navigator.language)
}