Skip to content

fix: fix html-validation error #1658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
eryue0220 wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

fix: fix html-validation error #1658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
65fcacd
fix html validation
eryue0220 Feb 26, 2026
573e631
Merge branch 'main' into fix/fix-html-validation-error
eryue0220 Feb 26, 2026
ef5755c
add transition
eryue0220 Feb 26, 2026
fabad0f
fix ut
eryue0220 Feb 26, 2026
0006681
fix error
eryue0220 Apr 17, 2026
3929351
fix conflict
eryue0220 Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/components/Package/ManagerSelect.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ function handleKeydown(event: KeyboardEvent) {
:aria-expanded="isOpen"
aria-haspopup="listbox"
:aria-label="$t('package.get_started.pm_label')"
:aria-controls="listboxId"
:aria-controls="isOpen ? listboxId : undefined"
@click="toggle"
@keydown="handleKeydown"
>
Expand Down Expand Up @@ -140,10 +140,11 @@ function handleKeydown(event: KeyboardEvent) {
:leave-to-class="prefersReducedMotion ? '' : 'opacity-0'"
>
<ul
v-if="isOpen"
v-show="isOpen"
:id="listboxId"
ref="listRef"
role="listbox"
:aria-hidden="!isOpen"
data-testid="package-manager-dropdown"
:aria-activedescendant="
highlightedIndex >= 0
Expand Down
11 changes: 7 additions & 4 deletions app/components/ReadmeTocDropdown.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ watch(
:aria-expanded="isOpen"
aria-haspopup="listbox"
:aria-label="$t('package.readme.toc_title')"
:aria-controls="listboxId"
:aria-controls="isOpen ? listboxId : undefined"
@click="toggle"
@keydown="handleKeydown"
classicon="i-lucide:list"
Expand All @@ -196,12 +196,15 @@ watch(
:leave-to-class="prefersReducedMotion ? '' : 'opacity-0'"
>
<div
v-if="isOpen"
v-show="isOpen"
:id="listboxId"
ref="listRef"
role="listbox"
:aria-hidden="!isOpen"
:aria-activedescendant="
highlightedIndex >= 0 ? `${listboxId}-${toc[highlightedIndex]?.id}` : undefined
highlightedIndex >= 0 && toc[highlightedIndex]?.id
? `${listboxId}-${toc[highlightedIndex]?.id}`
: undefined
"
:aria-label="$t('package.readme.toc_title')"
:style="getDropdownStyle()"
Expand Down Expand Up @@ -252,7 +255,7 @@ watch(
:aria-selected="activeId === grandchild.id"
class="flex items-center gap-2 px-3 py-1.5 ps-9 text-sm cursor-pointer transition-colors duration-150"
:class="[
activeId === grandchild.id ? 'text-fg font-medium' : 'text-fg-subtle',
grandchild.id === activeId ? 'text-fg font-medium' : 'text-fg-subtle',
highlightedIndex === getIndex(grandchild.id)
? 'bg-bg-elevated'
: 'hover:bg-bg-elevated',
Expand Down
14 changes: 7 additions & 7 deletions docs/app/components/BadgeGenerator.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const copyToClipboard = async () => {
class="my-8 p-5 rounded-xl border border-gray-200/60 dark:border-white/5 bg-gray-50/50 dark:bg-white/2 flex flex-col sm:flex-row items-end gap-4"
>
<div class="flex flex-col gap-1.5 flex-1 w-full">
<label class="text-[11px] font-bold uppercase tracking-wider text-gray-400 ml-1"
<label class="text-2xs font-bold uppercase tracking-wider text-gray-400 ms-1"
>Package Name</label
>
<input
Expand All @@ -36,7 +36,7 @@ const copyToClipboard = async () => {
</div>

<div class="flex flex-col gap-1.5 flex-1 w-full">
<label class="text-[11px] font-bold uppercase tracking-wider text-gray-400 ml-1"
<label class="text-2xs font-bold uppercase tracking-wider text-gray-400 ms-1"
>Badge Type</label
>
<div class="relative">
Expand All @@ -49,20 +49,20 @@ const copyToClipboard = async () => {
</option>
</select>
<span
class="absolute right-3 top-1/2 -translate-y-1/2 i-lucide-chevron-down w-4 h-4 text-gray-400 pointer-events-none"
class="absolute inset-ie-3 top-1/2 -translate-y-1/2 i-lucide-chevron-down w-4 h-4 text-gray-400 pointer-events-none"
/>
</div>
</div>

<div class="flex flex-col gap-1.5 flex-2 w-full">
<label class="text-[11px] font-bold uppercase tracking-wider text-gray-400 ml-1"
<label class="text-2xs font-bold uppercase tracking-wider text-gray-400 ms-1"
>Preview & Action</label
>
<div
class="flex items-center bg-white dark:bg-black/20 border border-gray-200 dark:border-white/10 rounded-lg h-10.5 overflow-hidden"
>
<div
class="flex-1 flex items-center justify-center px-3 border-r border-gray-200 dark:border-white/10 h-full bg-gray-50/50 dark:bg-transparent"
class="flex-1 flex items-center justify-center px-3 border-ie border-gray-200 dark:border-white/10 h-full bg-gray-50/50 dark:bg-transparent"
>
<img
v-if="isValid"
Expand All @@ -71,15 +71,15 @@ const copyToClipboard = async () => {
alt="Badge Preview"
@error="isValid = false"
/>
<span v-else class="text-[10px] font-bold text-red-500 uppercase tracking-tighter"
<span v-else class="text-3xs font-bold text-red-500 uppercase tracking-tighter"
>Invalid</span
>
</div>

<button
@click="copyToClipboard"
:disabled="!isValid || !pkg"
class="px-4 h-full text-[11px] font-bold uppercase tracking-widest transition-all disabled:opacity-20 disabled:cursor-not-allowed min-w-21.25 hover:bg-gray-50 dark:hover:bg-white/5"
class="px-4 h-full text-2xs font-bold uppercase tracking-widest transition-all disabled:opacity-20 disabled:cursor-not-allowed min-w-21.25 hover:bg-gray-50 dark:hover:bg-white/5"
:class="
copied
? 'text-emerald-500 bg-emerald-50/50 dark:bg-emerald-500/10'
Expand Down
42 changes: 21 additions & 21 deletions docs/app/components/BadgeGeneratorParameters.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ const copyToClipboard = async () => {
>
<div class="flex flex-col lg:flex-row items-end gap-4">
<div class="flex flex-col gap-1.5 flex-1 w-full">
<label class="text-[11px] font-bold uppercase tracking-wider text-gray-400 ml-1"
<label class="text-2xs font-bold uppercase tracking-wider text-gray-400 ms-1"
>Package Name</label
>
<input
Expand All @@ -82,7 +82,7 @@ const copyToClipboard = async () => {
</div>

<div class="flex flex-col gap-1.5 flex-1 w-full">
<label class="text-[11px] font-bold uppercase tracking-wider text-gray-400 ml-1"
<label class="text-2xs font-bold uppercase tracking-wider text-gray-400 ms-1"
>Badge Type</label
>
<div class="relative">
Expand All @@ -95,20 +95,20 @@ const copyToClipboard = async () => {
</option>
</select>
<span
class="absolute right-3 top-1/2 -translate-y-1/2 i-lucide-chevron-down w-4 h-4 text-gray-400 pointer-events-none"
class="absolute inset-ie-3 top-1/2 -translate-y-1/2 i-lucide-chevron-down w-4 h-4 text-gray-400 pointer-events-none"
/>
</div>
</div>

<div class="flex flex-col gap-1.5 flex-2 w-full">
<label class="text-[11px] font-bold uppercase tracking-wider text-gray-400 ml-1"
<label class="text-2xs font-bold uppercase tracking-wider text-gray-400 ms-1"
>Preview & Action</label
>
<div
class="flex items-center bg-white dark:bg-black/20 border border-gray-200 dark:border-white/10 rounded-lg h-10.5 overflow-hidden"
>
<div
class="flex-1 flex items-center justify-center px-3 border-r border-gray-200 dark:border-white/10 h-full bg-gray-50/10 dark:bg-transparent"
class="flex-1 flex items-center justify-center px-3 border-ie border-gray-200 dark:border-white/10 h-full bg-gray-50/10 dark:bg-transparent"
>
<img
v-if="isValid && isInputValid"
Expand All @@ -117,14 +117,14 @@ const copyToClipboard = async () => {
alt="Badge Preview"
@error="isValid = false"
/>
<span v-else class="text-[10px] font-bold text-red-500 uppercase tracking-tighter">
<span v-else class="text-3xs font-bold text-red-500 uppercase tracking-tighter">
{{ !isInputValid ? 'Invalid Parameters' : 'Not Found' }}
</span>
</div>
<button
@click="copyToClipboard"
:disabled="!isValid || !isInputValid || !pkg"
class="px-6 h-full text-[11px] font-bold uppercase tracking-widest transition-all disabled:opacity-20 disabled:cursor-not-allowed min-w-24 hover:bg-gray-50 dark:hover:bg-white/5"
class="px-6 h-full text-2xs font-bold uppercase tracking-widest transition-all disabled:opacity-20 disabled:cursor-not-allowed min-w-24 hover:bg-gray-50 dark:hover:bg-white/5"
:class="
copied
? 'text-emerald-500 bg-emerald-50/50 dark:bg-emerald-500/10'
Expand All @@ -141,15 +141,15 @@ const copyToClipboard = async () => {

<div class="grid grid-cols-1 sm:grid-cols-4 gap-6">
<div class="flex flex-col gap-1.5">
<label class="text-[10px] font-bold uppercase text-gray-400 ml-1">Label Text</label>
<label class="text-3xs font-bold uppercase text-gray-400 ms-1">Label Text</label>
<div class="relative group">
<input
v-model="labelText"
:disabled="usePkgName"
type="text"
placeholder="Custom Label"
class="w-full px-3 py-2 h-9 rounded-lg border border-gray-200 dark:border-white/10 bg-white dark:bg-black/20 text-xs outline-none focus:border-emerald-500 disabled:cursor-not-allowed transition-all"
:class="{ 'opacity-50 grayscale pl-3': usePkgName }"
:class="{ 'opacity-50 grayscale ps-3': usePkgName }"
/>

<transition
Expand All @@ -162,10 +162,10 @@ const copyToClipboard = async () => {
>
<div
v-if="usePkgName"
class="absolute right-1.5 top-1/2 -translate-y-1/2 pointer-events-none"
class="absolute inset-ie-1.5 top-1/2 -translate-y-1/2 pointer-events-none"
>
<span
class="flex items-center gap-1 px-1.5 py-0.5 rounded-md bg-emerald-500/10 dark:bg-emerald-500/20 text-emerald-500 text-[9px] font-bold uppercase tracking-tighter border border-emerald-500/20"
class="flex items-center gap-1 px-1.5 py-0.5 rounded-md bg-emerald-500/10 dark:bg-emerald-500/20 text-emerald-500 text-4xs font-bold uppercase tracking-tighter border border-emerald-500/20"
>
Auto
</span>
Expand All @@ -175,7 +175,7 @@ const copyToClipboard = async () => {
</div>

<div class="flex flex-col gap-1.5">
<label class="text-[10px] font-bold uppercase text-gray-400 ml-1">Badge Value</label>
<label class="text-3xs font-bold uppercase text-gray-400 ms-1">Badge Value</label>
<input
v-model="badgeValue"
type="text"
Expand All @@ -185,7 +185,7 @@ const copyToClipboard = async () => {
</div>

<div class="flex flex-col gap-1.5">
<label class="text-[10px] font-bold uppercase text-gray-400 ml-1">Label Color</label>
<label class="text-3xs font-bold uppercase text-gray-400 ms-1">Label Color</label>
<div
class="flex items-center px-3 rounded-lg border bg-white dark:bg-black/20 transition-all"
:class="
Expand All @@ -194,7 +194,7 @@ const copyToClipboard = async () => {
: 'border-red-500 ring-1 ring-red-500/20'
"
>
<span class="text-gray-400 text-xs font-mono mr-1">#</span>
<span class="text-gray-400 text-xs font-mono me-1">#</span>
<input
v-model="labelColor"
type="text"
Expand All @@ -203,13 +203,13 @@ const copyToClipboard = async () => {
/>
<span
v-if="!isLabelHexValid"
class="i-lucide-alert-circle w-3.5 h-3.5 text-red-500 ml-1"
class="i-lucide-alert-circle w-3.5 h-3.5 text-red-500 ms-1"
/>
</div>
</div>

<div class="flex flex-col gap-1.5">
<label class="text-[10px] font-bold uppercase text-gray-400 ml-1">Badge Color</label>
<label class="text-3xs font-bold uppercase text-gray-400 ms-1">Badge Color</label>
<div
class="flex items-center px-3 rounded-lg border bg-white dark:bg-black/20 transition-all"
:class="
Expand All @@ -218,7 +218,7 @@ const copyToClipboard = async () => {
: 'border-red-500 ring-1 ring-red-500/20'
"
>
<span class="text-gray-400 text-xs font-mono mr-1">#</span>
<span class="text-gray-400 text-xs font-mono me-1">#</span>
<input
v-model="badgeColor"
type="text"
Expand All @@ -227,7 +227,7 @@ const copyToClipboard = async () => {
/>
<span
v-if="!isBadgeHexValid"
class="i-lucide-alert-circle w-3.5 h-3.5 text-red-500 ml-1"
class="i-lucide-alert-circle w-3.5 h-3.5 text-red-500 ms-1"
/>
</div>
</div>
Expand All @@ -239,16 +239,16 @@ const copyToClipboard = async () => {
<label class="relative inline-flex items-center cursor-pointer group">
<input v-model="usePkgName" type="checkbox" class="sr-only peer" />
<div
class="w-9 h-5 bg-gray-200 peer-focus:outline-none dark:bg-white/10 peer-checked:after:translate-x-full peer-checked:after:border-white after:content-[''] after:absolute after:top-0.5 after:left-0.5 after:bg-white after:border-gray-300 after:border after:rounded-full after:h-4 after:w-4 after:transition-all peer-checked:bg-emerald-500 rounded-full"
class="w-9 h-5 bg-gray-200 peer-focus:outline-none dark:bg-white/10 peer-checked:after:translate-x-full peer-checked:after:border-white after:content-[''] after:absolute after:top-0.5 after:inset-is-0.5 after:bg-white after:border-gray-300 after:border after:rounded-full after:h-4 after:w-4 after:transition-all peer-checked:bg-emerald-500 rounded-full"
></div>
<span
class="ml-3 text-[10px] font-bold uppercase text-gray-400 group-hover:text-gray-600 dark:group-hover:text-gray-300 transition-colors"
class="ms-3 text-3xs font-bold uppercase text-gray-400 group-hover:text-gray-600 dark:group-hover:text-gray-300 transition-colors"
>Use package name as label</span
>
</label>

<div class="flex items-center gap-3">
<label class="text-[10px] font-bold uppercase text-gray-400 whitespace-nowrap"
<label class="text-3xs font-bold uppercase text-gray-400 whitespace-nowrap"
>Badge Style</label
>
<select
Expand Down
5 changes: 4 additions & 1 deletion nuxt.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,10 @@ export default defineNuxtConfig({
htmlValidator: {
enabled: !isCI || (provider !== 'vercel' && !!process.env.VALIDATE_HTML),
options: {
rules: { 'meta-refresh': 'off' },
rules: {
'meta-refresh': 'off',
'prefer-native-element': ['error', { exclude: ['listbox'] }],
Copy link
Copy Markdown
Member

@serhalp serhalp Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Per https://discord.com/channels/1464542801676206113/1464926468751753269/1471511992434163844, I think if anything we'd want exactly the opposite (include), wouldn't we? As is this would suppress warnings about role=listbox, which we do want to eliminate.

Copy link
Copy Markdown
Contributor Author

@eryue0220 eryue0220 Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the goal is to rewrite those components which their attribute is role=listbox, right?

},
},
failOnError: true,
},
Expand Down
Loading