Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughTrigger buttons in two dropdown components now set Changes
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| rules: { 'meta-refresh': 'off' }, | ||
| rules: { | ||
| 'meta-refresh': 'off', | ||
| 'prefer-native-element': ['error', { exclude: ['listbox'] }], |
There was a problem hiding this comment.
🤔 Per https://discord.com/channels/1464542801676206113/1464926468751753269/1471511992434163844, I think if anything we'd want exactly the opposite (include), wouldn't we? As is this would suppress warnings about role=listbox, which we do want to eliminate.
There was a problem hiding this comment.
So the goal is to rewrite those components which their attribute is role=listbox, right?
ghostdevv
left a comment
There was a problem hiding this comment.
@eryue0220 would you be up for updating this PR? I think it is still valid, not sure if these are the same issues though 🙏
ERROR HTML validation errors found for /package/@pnpm/workspace.find-packages 23:03:55
inline
38:34256 error Element references missing id "v-0-3-listbox" no-missing-references
38:77153 error Element references missing id "v-0-6-toc-listbox" no-missing-references
✖ 2 problems (2 errors, 0 warnings)
Okay, I'll check that and update these cases. |
🔗 Linked issue
Resolve #1425
🧭 Context
Fix html-validation lint error when visit page
/package/@pnpm/workspace.find-packages📚 Description
prefer-native-elementwhen the element role islistbox