feat: add package manager tabs to local connector install command#199
Closed
jonathanyeong wants to merge 1 commit intonpmx-dev:mainfrom
Closed
feat: add package manager tabs to local connector install command#199jonathanyeong wants to merge 1 commit intonpmx-dev:mainfrom
jonathanyeong wants to merge 1 commit intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
Thanks for the review @serhalp! I'm going to close this PR for now. From Discord discussions, we don't want to show the tabs in the connector modal and maybe putting it in the new settings page is better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current behaviour
We keep track of the selected package manager when we change it in the package. But it's not clear that I had selected that package manager in the first place when trying to install local connector.
current-behaviour.mp4
New behaviour
package-manager-tabs.mp4