Skip to content

feat: add package manager tabs to local connector install command #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jonathanyeong wants to merge 1 commit into from
Closed

feat: add package manager tabs to local connector install command #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions app/components/ConnectorModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,14 @@ watch(open, isOpen => {
{{ $t('connector.modal.run_hint') }}
</p>

<div
class="inline-flex items-center gap-1 p-0.5 bg-bg-subtle border border-border-subtle rounded-md"
role="tablist"
:aria-label="$t('package.install.pm_label')"
>
<PackageManagerTabs v-model="selectedPM" />
</div>

<div
class="flex items-center p-3 bg-[#0d0d0d] border border-border rounded-lg font-mono text-sm"
>
Expand Down
34 changes: 34 additions & 0 deletions app/components/PackageManagerTabs.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
<script setup lang="ts">
const selectedPM = defineModel<PackageManagerId>({ required: true })
</script>

<template>
<ClientOnly>
<button
v-for="pm in packageManagers"
:key="pm.id"
type="button"
role="tab"
:aria-selected="selectedPM === pm.id"
class="px-2 py-1 font-mono text-xs rounded transition-colors duration-150 border border-solid focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-fg/50"
:class="
selectedPM === pm.id
? 'bg-bg shadow text-fg border-border'
: 'text-fg-subtle hover:text-fg border-transparent'
"
@click="selectedPM = pm.id"
>
{{ pm.label }}
</button>
<template #fallback>
<span
v-for="pm in packageManagers"
:key="pm.id"
class="px-2 py-1 font-mono text-xs rounded"
:class="pm.id === 'npm' ? 'bg-bg-elevated text-fg' : 'text-fg-subtle'"
>
{{ pm.label }}
</span>
</template>
</ClientOnly>
</template>
28 changes: 1 addition & 27 deletions app/pages/[...package].vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -785,33 +785,7 @@ defineOgImageComponent('Package', {
role="tablist"
:aria-label="$t('package.install.pm_label')"
>
<ClientOnly>
<button
v-for="pm in packageManagers"
:key="pm.id"
role="tab"
:aria-selected="selectedPM === pm.id"
class="px-2 py-1 font-mono text-xs rounded transition-colors duration-150 border border-solid focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-fg/50"
:class="
selectedPM === pm.id
? 'bg-bg shadow text-fg border-border'
: 'text-fg-subtle hover:text-fg border-transparent'
"
@click="selectedPM = pm.id"
>
{{ pm.label }}
</button>
<template #fallback>
<span
v-for="pm in packageManagers"
:key="pm.id"
class="px-2 py-1 font-mono text-xs rounded"
:class="pm.id === 'npm' ? 'bg-bg-elevated text-fg' : 'text-fg-subtle'"
>
{{ pm.label }}
</span>
</template>
</ClientOnly>
<PackageManagerTabs v-model="selectedPM" />
</div>
</div>
<div class="relative group">
Expand Down