chore: Add warning message from #17 to the cli as well#20
Merged
danielroe merged 7 commits intonpmx-dev:mainfrom Jan 24, 2026
Merged
chore: Add warning message from #17 to the cli as well#20danielroe merged 7 commits intonpmx-dev:mainfrom
danielroe merged 7 commits intonpmx-dev:mainfrom
Conversation
|
@neutrino2211 is attempting to deploy a commit to the danielroe Team on Vercel. A member of the Team first needs to authorize it. |
danielroe
reviewed
Jan 24, 2026
|
|
||
| if (!npmUser) { | ||
| logWarning('Not logged in to npm. Starting npm login...') | ||
| logWarning('This allows npmx to access your npm cli and any authenticated contexts.') |
Member
There was a problem hiding this comment.
we should display the warning even if user is already logged into npm
Contributor
Author
There was a problem hiding this comment.
Okay. Should the message be before or after the "Checking npm authentication..." Message?
Member
There was a problem hiding this comment.
maybe it should be on startup, and require you to confirm you still want to proceed?
Contributor
Author
There was a problem hiding this comment.
That makes sense
Contributor
Author
|
It now
|
vinnymac
pushed a commit
to vinnymac/npmx.dev
that referenced
this pull request
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the warning message in the UI to the cli logs. Currently done in separate lines.