Skip to content

chore: Add warning message from #17 to the cli as well #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 7 commits into from
Jan 24, 2026
Merged

chore: Add warning message from #17 to the cli as well #20

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e76c1f3
chore: add warning message in ConnectorModal for npm cli access
neutrino2211 Jan 24, 2026
66b2bc9
fix: Only allow connections from npmx.dev or localhost:3000
neutrino2211 Jan 24, 2026
15b8f5d
Merge branch 'main' of https://github.com/neutrino2211/npmx.dev
neutrino2211 Jan 24, 2026
dc2823c
chore: Add warning from #17 to the cli as well.
neutrino2211 Jan 24, 2026
f9a2da1
Merge branch 'danielroe:main' into main
neutrino2211 Jan 24, 2026
6d6a6c7
Move warning message to show on startup
neutrino2211 Jan 24, 2026
3ae2503
chore: add underline and default to 'yes'
danielroe Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cli/src/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ const main = defineCommand({

if (!npmUser) {
logWarning('Not logged in to npm. Starting npm login...')
logWarning('This allows npmx to access your npm cli and any authenticated contexts.')
Copy link
Copy Markdown
Member

@danielroe danielroe Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should display the warning even if user is already logged into npm

Copy link
Copy Markdown
Contributor Author

@neutrino2211 neutrino2211 Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Should the message be before or after the "Checking npm authentication..." Message?

Copy link
Copy Markdown
Member

@danielroe danielroe Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it should be on startup, and require you to confirm you still want to proceed?

Copy link
Copy Markdown
Contributor Author

@neutrino2211 neutrino2211 Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense

// oxlint-disable-next-line no-console -- deliberate spacing
console.log()

Expand Down