fix: use seamless skeleton shift on sparkline#391
Merged
danielroe merged 6 commits intonpmx-dev:mainfrom Jan 30, 2026
Merged
Conversation
Contributor
graphieros
commented
Jan 30, 2026
graphieros
commented
- bump vue-data-ui to 3.13.7 (open skeleton config & dataset to customization)
- apply custom configuration on the sparkline's built-in skeleton for a seamless transition between mounted and final state
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
userquin
reviewed
Jan 30, 2026
userquin
reviewed
Jan 30, 2026
userquin
reviewed
Jan 30, 2026
Member
|
this increases CLS (probably the changes you made to the skelelton) here's a video, first of the current main branch (which has approx 1px CLS - which I need to fix) and then this PR branch: Screen.Recording.2026-01-30.at.09.16.23.mov |
Contributor
Author
Gonna check |
Contributor
Author
|
hardcoding min-h seems to fix it (not the most elegant fix though) |
danielroe
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.