fix: add skeleton for pre-hydration toggles#541
Merged
danielroe merged 2 commits intonpmx-dev:mainfrom Jan 31, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
MatteoGabriele
changed the title
MatteoGabriele
changed the title
danielroe
reviewed
Jan 31, 2026
| </span> | ||
| </button> | ||
| <template #fallback> | ||
| <ToggleSkeleton :label="$t('settings.relative_dates')" /> |
Member
There was a problem hiding this comment.
btw, you can also do this with Toggle.server.vue and Toggle.client.vue (with the .server.vue component being the skeleton)
Member
Author
There was a problem hiding this comment.
oh wow! I've never thought about that. Pretty cool.
I can improve this later with a proper toggle component or handle it here in the same PR. Whatever you think is best.
danielroe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the mismatch in the saved value of "Relative dates" toggle.
It also adds a skeleton placeholder for all toggles on the settings page.
Screen.Recording.2026-01-31.at.19.59.05.mov