Skip to content

fix: add skeleton for pre-hydration toggles #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 2 commits into from
Jan 31, 2026
Merged

fix: add skeleton for pre-hydration toggles #541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce3d6da
fix(settings): relative dates is always false by default
MatteoGabriele Jan 31, 2026
244406a
Merge branch 'main' into fix/settings-relative-dates-mismatch
MatteoGabriele Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions app/components/ToggleSkeleton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<script setup lang="ts">
defineProps<{
label: string
}>()
</script>

<template>
<div class="w-full flex items-center justify-between gap-4">
<span class="text-sm text-fg font-medium text-start">
{{ label }}
</span>
<span class="skeleton block h-6 w-11 shrink-0 rounded-full" />
</div>
</template>
139 changes: 78 additions & 61 deletions app/pages/settings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,27 +101,32 @@ defineOgImageComponent('Default', {
<div class="bg-bg-subtle border border-border rounded-lg p-4 sm:p-6 space-y-4">
<!-- Relative dates toggle -->
<div class="space-y-2">
<button
type="button"
class="w-full flex items-center justify-between gap-4 group"
role="switch"
:aria-checked="settings.relativeDates"
@click="settings.relativeDates = !settings.relativeDates"
>
<span class="text-sm text-fg font-medium text-start">
{{ $t('settings.relative_dates') }}
</span>
<span
class="relative inline-flex h-6 w-11 shrink-0 items-center rounded-full border-2 border-transparent transition-colors duration-200 ease-in-out motion-reduce:transition-none shadow-sm cursor-pointer"
:class="settings.relativeDates ? 'bg-accent' : 'bg-bg border border-border'"
aria-hidden="true"
<ClientOnly>
<button
type="button"
class="w-full flex items-center justify-between gap-4 group"
role="switch"
:aria-checked="settings.relativeDates"
@click="settings.relativeDates = !settings.relativeDates"
>
<span class="text-sm text-fg font-medium text-start">
{{ $t('settings.relative_dates') }}
</span>
<span
class="pointer-events-none inline-block h-5 w-5 rounded-full shadow-sm ring-0 transition-transform duration-200 ease-in-out motion-reduce:transition-none"
:class="settings.relativeDates ? 'bg-bg' : 'bg-fg-muted'"
/>
</span>
</button>
class="relative inline-flex h-6 w-11 shrink-0 items-center rounded-full border-2 border-transparent transition-colors duration-200 ease-in-out motion-reduce:transition-none shadow-sm cursor-pointer"
:class="settings.relativeDates ? 'bg-accent' : 'bg-bg border border-border'"
aria-hidden="true"
>
<span
class="pointer-events-none inline-block h-5 w-5 rounded-full shadow-sm ring-0 transition-transform duration-200 ease-in-out motion-reduce:transition-none"
:class="settings.relativeDates ? 'bg-bg' : 'bg-fg-muted'"
/>
</span>
</button>
<template #fallback>
<ToggleSkeleton :label="$t('settings.relative_dates')" />
Copy link
Copy Markdown
Member

@danielroe danielroe Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, you can also do this with Toggle.server.vue and Toggle.client.vue (with the .server.vue component being the skeleton)

Copy link
Copy Markdown
Member Author

@MatteoGabriele MatteoGabriele Jan 31, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wow! I've never thought about that. Pretty cool.
I can improve this later with a proper toggle component or handle it here in the same PR. Whatever you think is best.

Copy link
Copy Markdown
Member

@danielroe danielroe Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's merge and iterate 🚀

</template>
</ClientOnly>
<p class="text-sm text-fg-muted">
{{ $t('settings.relative_dates_description') }}
</p>
Expand All @@ -132,29 +137,34 @@ defineOgImageComponent('Default', {

<!-- Include @types in install toggle -->
<div class="space-y-2">
<button
type="button"
class="w-full flex items-center justify-between gap-4 group"
role="switch"
:aria-checked="settings.includeTypesInInstall"
@click="settings.includeTypesInInstall = !settings.includeTypesInInstall"
>
<span class="text-sm text-fg font-medium text-start">
{{ $t('settings.include_types') }}
</span>
<span
class="relative inline-flex h-6 w-11 shrink-0 items-center rounded-full border-2 border-transparent transition-colors duration-200 ease-in-out motion-reduce:transition-none shadow-sm cursor-pointer"
:class="
settings.includeTypesInInstall ? 'bg-accent' : 'bg-bg border border-border'
"
aria-hidden="true"
<ClientOnly>
<button
type="button"
class="w-full flex items-center justify-between gap-4 group"
role="switch"
:aria-checked="settings.includeTypesInInstall"
@click="settings.includeTypesInInstall = !settings.includeTypesInInstall"
>
<span class="text-sm text-fg font-medium text-start">
{{ $t('settings.include_types') }}
</span>
<span
class="pointer-events-none inline-block h-5 w-5 rounded-full shadow-sm ring-0 transition-transform duration-200 ease-in-out motion-reduce:transition-none"
:class="settings.includeTypesInInstall ? 'bg-bg' : 'bg-fg-muted'"
/>
</span>
</button>
class="relative inline-flex h-6 w-11 shrink-0 items-center rounded-full border-2 border-transparent transition-colors duration-200 ease-in-out motion-reduce:transition-none shadow-sm cursor-pointer"
:class="
settings.includeTypesInInstall ? 'bg-accent' : 'bg-bg border border-border'
"
aria-hidden="true"
>
<span
class="pointer-events-none inline-block h-5 w-5 rounded-full shadow-sm ring-0 transition-transform duration-200 ease-in-out motion-reduce:transition-none"
:class="settings.includeTypesInInstall ? 'bg-bg' : 'bg-fg-muted'"
/>
</span>
</button>
<template #fallback>
<ToggleSkeleton :label="$t('settings.include_types')" />
</template>
</ClientOnly>
<p class="text-sm text-fg-muted">
{{ $t('settings.include_types_description') }}
</p>
Expand All @@ -165,29 +175,36 @@ defineOgImageComponent('Default', {

<!-- Hide platform-specific packages toggle -->
<div class="space-y-2">
<button
type="button"
class="w-full flex items-center justify-between gap-4 group"
role="switch"
:aria-checked="settings.hidePlatformPackages"
@click="settings.hidePlatformPackages = !settings.hidePlatformPackages"
>
<span class="text-sm text-fg font-medium text-start">
{{ $t('settings.hide_platform_packages') }}
</span>
<span
class="relative inline-flex h-6 w-11 shrink-0 items-center rounded-full border-2 border-transparent transition-colors duration-200 ease-in-out motion-reduce:transition-none shadow-sm cursor-pointer"
:class="
settings.hidePlatformPackages ? 'bg-accent' : 'bg-bg border border-border'
"
aria-hidden="true"
<ClientOnly>
<button
type="button"
class="w-full flex items-center justify-between gap-4 group"
role="switch"
:aria-checked="settings.hidePlatformPackages"
@click="settings.hidePlatformPackages = !settings.hidePlatformPackages"
>
<span class="text-sm text-fg font-medium text-start">
{{ $t('settings.hide_platform_packages') }}
</span>
<span
class="pointer-events-none inline-block h-5 w-5 rounded-full shadow-sm ring-0 transition-transform duration-200 ease-in-out motion-reduce:transition-none"
:class="settings.hidePlatformPackages ? 'bg-bg' : 'bg-fg-muted'"
/>
</span>
</button>
class="relative inline-flex h-6 w-11 shrink-0 items-center rounded-full border-2 border-transparent transition-colors duration-200 ease-in-out motion-reduce:transition-none shadow-sm cursor-pointer"
:class="
settings.hidePlatformPackages ? 'bg-accent' : 'bg-bg border border-border'
"
aria-hidden="true"
>
<span
class="pointer-events-none inline-block h-5 w-5 rounded-full shadow-sm ring-0 transition-transform duration-200 ease-in-out motion-reduce:transition-none"
:class="settings.hidePlatformPackages ? 'bg-bg' : 'bg-fg-muted'"
/>
</span>
</button>
<template #fallback>
<p class="text-sm text-fg-muted">
{{ $t('settings.hide_platform_packages') }}
</p>
</template>
</ClientOnly>
<p class="text-sm text-fg-muted">
{{ $t('settings.hide_platform_packages_description') }}
</p>
Expand Down
Loading