fix: show "none" if package has no license#656
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Great idea! We'll need translations for the word "None". The files live in i18n/locales. We may need to mobilise the i18n team in the Discord! Would be good to post in the channel: https://discord.com/channels/1464542801676206113/1465734070817259601 |
| <dd class="font-mono text-sm text-fg"> | ||
| <LicenseDisplay :license="pkg.license" /> | ||
| <LicenseDisplay v-if="pkg.license" :license="pkg.license" /> | ||
| <span v-else>None</span> |
There was a problem hiding this comment.
Additionally to what @whitep4nth3r said here #656 (comment)
You could add the variant for english in en.json, IIRC $t('package.license.none') should be according to the naming schema for language keys.
The i18n:check for the language files should then be automagically infer that the key is missing for the respective file.
There was a problem hiding this comment.
Thank you so much @stephfh! I configured the variant in en.json, want to have a second look?
There was a problem hiding this comment.
Looks good on my machine. :D
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Thank you so much @whitep4nth3r . I've made some changes and will reach out in the i18n channel. |
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
4 participants
Currently we hide the license column if there's no license. With this PR render "None" instead, similar to what npmjs.com does.