Skip to content

fix: show "none" if package has no license #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 3 commits into from
Feb 1, 2026
Merged

fix: show "none" if package has no license #656

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e19013
Show "none" if package has no license
Nadjaroemer Feb 1, 2026
b382c0f
Make sure "none" messages uses localization
Nadjaroemer Feb 1, 2026
1390313
[autofix.ci] apply automated fixes
autofix-ci[bot] Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/pages/[...package].vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,12 +735,13 @@ function handleClick(event: MouseEvent) {
<dl
class="grid grid-cols-2 sm:grid-cols-11 gap-3 sm:gap-4 py-4 sm:py-6 mt-4 sm:mt-6 border-t border-b border-border"
>
<div v-if="pkg.license" class="space-y-1 sm:col-span-2">
<div class="space-y-1 sm:col-span-2">
<dt class="text-xs text-fg-subtle uppercase tracking-wider">
{{ $t('package.stats.license') }}
</dt>
<dd class="font-mono text-sm text-fg">
<LicenseDisplay :license="pkg.license" />
<LicenseDisplay v-if="pkg.license" :license="pkg.license" />
<span v-else>None</span>
Copy link
Copy Markdown
Contributor

@stephfh stephfh Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally to what @whitep4nth3r said here #656 (comment)

You could add the variant for english in en.json, IIRC $t('package.license.none') should be according to the naming schema for language keys.

The i18n:check for the language files should then be automagically infer that the key is missing for the respective file.

Copy link
Copy Markdown
Contributor Author

@Nadjaroemer Nadjaroemer Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @stephfh! I configured the variant in en.json, want to have a second look?

Copy link
Copy Markdown
Contributor

@stephfh stephfh Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my machine. :D

</dd>
</div>

Expand Down
Loading