Repository navigation
Conversation
tmakatos
force-pushed
the
per-vm-log-layer
branch
2 times, most recently
from
October 22, 2026 11:41
6c5c184 to
7f86264
Compare
tmakatos
marked this pull request as ready for review
October 22, 2026 11:42
tmakatos
force-pushed
the
per-vm-log-layer
branch
2 times, most recently
from
October 22, 2026 13:20
0531b7f to
5d6d55c
Compare
tmakatos
force-pushed
the
per-vm-log-layer
branch
from
October 22, 2026 13:36
5d6d55c to
a87b62a
Compare
tmakatos
force-pushed
the
per-vm-log-layer
branch
from
October 22, 2026 13:38
a87b62a to
e1f9ee1
Compare
tmakatos
force-pushed
the
per-vm-log-layer
branch
2 times, most recently
from
October 22, 2026 13:43
1e65971 to
cded577
Compare
tmakatos
force-pushed
the
per-vm-log-layer
branch
from
October 22, 2026 13:46
cded577 to
54e3ea7
Compare
tmakatos
force-pushed
the
per-vm-log-layer
branch
3 times, most recently
from
October 22, 2026 16:45
8a9ad4d to
bd2d421
Compare
tmakatos
force-pushed
the
per-vm-log-layer
branch
from
October 23, 2026 07:13
bd2d421 to
c5ebfa9
Compare
tmakatos
force-pushed
the
per-vm-log-layer
branch
from
October 23, 2026 07:23
c5ebfa9 to
e39bfdb
Compare
lforchini
requested changes
Oct 26, 2026
tmakatos
force-pushed
the
per-vm-log-layer
branch
5 times, most recently
from
October 26, 2026 16:44
81d36c0 to
7b2a962
Compare
tmakatos
force-pushed
the
per-vm-log-layer
branch
from
October 26, 2026 17:02
7b2a962 to
703f9d0
Compare
Every per-VM event was logged twice, once through tracing and once as a hand-formatted line for the per-VM file, and events logged elsewhere, such as the threshold engine's scaling decisions, never reached the per-VM file at all. Add a tracing layer that copies every event carrying a vm field to that VM's file, without the vm field, and log per-VM events only once. Status and lifecycle records use a dedicated per_vm target that the main log filters out, so they still only go to the per-VM files. The layer has its own INFO filter, so RUST_LOG no longer affects the per-VM files. Use vm consistently for the VM ID field, instead of id or uuid, so that those events are routed too. AI-generated: everything Signed-off-by: Thanos Makatos <thanos.makatos@nutanix.com>
Signed-off-by: Thanos Makatos <thanos.makatos@nutanix.com>
Signed-off-by: Thanos Makatos <thanos.makatos@nutanix.com>
tmakatos
force-pushed
the
per-vm-log-layer
branch
from
October 26, 2026 18:08
703f9d0 to
e95a2dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every per-VM event was logged twice, once through tracing and once as
a hand-formatted line for the per-VM file, and events logged elsewhere,
such as the threshold engine's scaling decisions, never reached the
per-VM file at all.
Add a tracing layer that copies every event carrying a vm field to that
VM's file, without the vm field, and log per-VM events only once. Status
and lifecycle records use a dedicated per_vm target that the main log
filters out, so they still only go to the per-VM files. The layer has
its own INFO filter, so RUST_LOG no longer affects the per-VM files.
Use vm consistently for the VM ID field, instead of id or uuid, so that
those events are routed too.
AI-generated: everything
Signed-off-by: Thanos Makatos thanos.makatos@nutanix.com
Stack created with GitHub Stacks CLI • Give Feedback 💬