Repository navigation
fix(konflux): skip prefetch tasks with empty input - #801
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
HyperShell environment deployingDeploying commit Comment |
|
All PipelineRuns for this commit have already succeeded. Use |
Add a no-op comment to each pipeline variant of the five components that had prefetch_dependencies.package_registry_proxy_enabled violations (api-server, cli, control-plane, web-console, fleet-dashboard) to trigger a fresh build and enterprise-contract evaluation. This verifies that #801 (skip the prefetch TaskRun on empty input) actually clears the violations. The per-component enterprise-contract checks on this PR are the proof. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Empty prefetch input currently creates a TaskRun whose only step is skipped. The deployed Conforma policy fails to read its already-true proxy parameter because the TaskRun has no
status.results, causing five application-wide EC violations.Skip the entire
prefetch-dependenciesPipelineTask whenprefetch-inputis empty for api-server, cli, control-plane, web-console, and fleet-dashboard, across push, pull-request, and merge-queue (15 files). Nonempty input still runs prefetch. The active policy already excludestasks.required_tasks_found:prefetch-dependencies; builds have no downstream references to prefetch results, and Tekton continues ordering-only dependents after a skipped task.This is an alternative to #800. It preserves the existing empty-input build behavior and requires no policy changes. The workaround addresses empty-input builds only; the upstream parameter-extraction bug remains relevant if prefetch is enabled later.
Validation:
make checkpassed.Policy bug source: https://github.com/conforma/policy/blob/fb1d3a6b7d70a6c43e045f0b38c77349a94faba2/policy/lib/tekton/task.rego#L30-L60
Tekton skip semantics: https://tekton.dev/docs/pipelines/pipelines/#guarding-a-task-only