Conversation
When a login is done using cookies we allow multiple concurrent logins to happen in parallel. This works on mobile and on desktop.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the LTI 1.3 Spring Security configuration to support multiple concurrent OIDC login flows when the browser is using cookies/session state, enabling parallel logins (e.g., multiple tabs/windows) on both mobile and desktop.
Changes:
- Override the default authorization request repository configuration to use a session-backed repository that supports multiple concurrent login requests.
- Add a state-based authorization request repository with a configured TTL and optional IP-limiting behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+32
to
+40
| @Override | ||
| protected OptimisticAuthorizationRequestRepository configureRequestRepository() { | ||
| HttpSessionOAuth2AuthorizationRequestRepository sessionRepository = new HttpSessionOAuth2AuthorizationRequestRepository(); | ||
| // We override the default HttpSession repository to allow concurrent logins to be stored. | ||
| sessionRepository.setMaxConcurrentLogins(10); | ||
| StateAuthorizationRequestRepository stateRepository = new StateAuthorizationRequestRepository(Duration.ofMinutes(1)); | ||
| stateRepository.setLimitIpAddress(limitIpAddresses); | ||
| return new OptimisticAuthorizationRequestRepository( sessionRepository, stateRepository ); | ||
| } |
sebastianchristopher
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a login is done using cookies we allow multiple concurrent logins to happen in parallel. This works on mobile and on desktop.