AB#127298 add Playwright smoke tests for deployment checks#223
Open
sebastianchristopher wants to merge 5 commits into
Open
AB#127298 add Playwright smoke tests for deployment checks#223sebastianchristopher wants to merge 5 commits into
sebastianchristopher wants to merge 5 commits into
Conversation
sebastianchristopher
requested review from
buckett,
Copilot,
lardo-de-arnaud and
nicholaswilson100
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new deployment/ Node/Playwright test harness plus a reusable GitHub Actions workflow intended to run smoke checks against deployed environments.
Changes:
- Introduces a Playwright-based smoke test that validates the deployed JWKS endpoint response shape.
- Adds a dedicated
deployment/npm project (Playwright config, package manifests, node version, env example, gitignore, README). - Adds a new reusable workflow (
Test Deployment) to run the deployment smoke tests in GitHub Actions.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| deployment/README.md | Documents how to install and run the deployment smoke tests. |
| deployment/playwright.config.js | Adds Playwright test runner configuration for deployment checks. |
| deployment/package.json | Defines the deployment test package, scripts, and dev dependencies. |
| deployment/package-lock.json | Locks Playwright/dotenv dependency tree for the deployment test package. |
| deployment/deployment.test.js | Implements the JWKS smoke test executed by Playwright. |
| deployment/.nvmrc | Pins the Node.js major version for running the deployment test package. |
| deployment/.gitignore | Ignores generated Playwright artifacts and node_modules for the deployment test package. |
| deployment/.env.example | Provides example environment variables for running deployment tests. |
| .github/workflows/test_deployment.yml | Adds the workflow that waits for the deployed app and runs the smoke tests. |
Files not reviewed (1)
- deployment/package-lock.json: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* construct JWKS url from base url
* construct JWKS url from base url
Comment on lines
+40
to
+41
| - name: Wait for the backend to start up and serve the index | ||
| run: curl -I --show-error --silent --retry 10 --retry-connrefused --retry-delay 10 ${{ env.URL }} |
| @@ -0,0 +1 @@ | |||
| URL=<tool support url e.g. https://tools.canvas.ox.ac.uk/> No newline at end of file | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.