Skip to content

fix: prevent inherited worker launch options - #185

Merged
jerome-benoit merged 1 commit into
masterfrom
fix/prevent-inherited-worker-options
Oct 15, 2026
Merged

jerome-benoit merged 1 commit into
masterfrom
fix/prevent-inherited-worker-options

Conversation

@jerome-benoit

@jerome-benoit jerome-benoit commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

PR Checklist

  • Title follows conventional commits.
  • Changes are described below.
  • Regression tests are included.
  • No new feature documentation is required.
  • Linked to the upstream security advisory below.

Does this PR introduce a breaking change?

  • No

Security impact

This port is affected on Bun: inherited worker launch options can reach executable options such as preload and execArgv after prototype pollution. Deno permission dictionaries can also consume inherited authority fields.

Upstream references:

Changes

  • forward only own worker launch options and rebuild launch dictionaries without prototypes;
  • preserve explicit runtime options, including non-enumerable Bun environment and Deno permission restrictions;
  • normalize Bun argv, execArgv, preload, and transferList arrays without inherited slots;
  • normalize nested Deno permission dictionaries and arrays from own properties;
  • restore pool startup flags when worker construction fails;
  • cover fixed, dynamic, descriptor, nested, sparse-array, and startup-recovery paths.

Verification

  • deno task format:check
  • deno task lint
  • deno task test:coverage — 260 steps passed
  • deno task coverage:report
  • deno task bundle
  • Bun exploit smoke: inherited options, preload, execArgv, and parent environment values do not reach the worker.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-14T23:30:00.369728Z 80ca2e2 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bbf7e5e684

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/pools/utils.ts Resolved
@jerome-benoit
jerome-benoit force-pushed the fix/prevent-inherited-worker-options branch from bbf7e5e to 80ca2e2 Compare October 14, 2026 23:27
@sonarqubecloud

Copy link
Copy Markdown

@jerome-benoit
jerome-benoit merged commit fd6ccce into master Oct 15, 2026
15 checks passed
@jerome-benoit
jerome-benoit deleted the fix/prevent-inherited-worker-options branch October 15, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant