Repository navigation
Store the full tcp-probe record on the Session - #3668
Merged
Merged
Conversation
goastler
marked this pull request as ready for review
November 9, 2026 16:22
goastler
force-pushed
the
tcp-probe-v2-signals
branch
from
November 9, 2026 16:26
25d6909 to
215b44c
Compare
goastler
force-pushed
the
tcp-probe-v2-signals
branch
from
November 9, 2026 16:43
c592557 to
2f91f6f
Compare
goastler
enabled auto-merge (squash)
November 9, 2026 17:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed: the provider now reads the new X-TCP-Probe header from chaddy, checks it, and saves it on the Session as tcpProbe, including on the bypass paths. Old X-TLS-* handling is unchanged.
Effect: we keep IPv6 connections, the packets after the first handshake, and a record of why a lookup missed. Nothing changes until chaddy sends the header.
Tests: unit tests cover decoding, IPv6, misses, absent, repeated, oversized, malformed and forged headers, plus the bypass path.