Repository navigation
Add 'filter_sea_ice' flag to the 'amsr2_l2_gaasp' reader - #3519
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3519 +/- ##
========================================
Coverage 96.42% 96.43%
========================================
Files 474 474
Lines 60784 60912 +128
========================================
+ Hits 58610 58738 +128
Misses 2174 2174
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See ssec/polar2grid#823 for details.
Adds 'filter_sea_ice' which does a simple
.whereonFlags == 0for quality.Addsfilter_sea_ice_qualityandfilter_sea_ice_swathto clear out a lot of unnecessary pixels.I still need to confirm that both types of filtering are needed as the types of files I had were "clean" after filtering just by the quality flag (says Claude).Code written by Claude with some edits by me.
CC @DougASchu
AUTHORS.mdif not there already