Skip to content

Add 'filter_sea_ice' flag to the 'amsr2_l2_gaasp' reader - #3519

Merged
djhoese merged 2 commits into
pytroll:mainfrom
djhoese:feat-gaasp-seaice-filters
Nov 5, 2026
Merged

djhoese merged 2 commits into
pytroll:mainfrom
djhoese:feat-gaasp-seaice-filters

Conversation

@djhoese

@djhoese djhoese commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

See ssec/polar2grid#823 for details.

Adds 'filter_sea_ice' which does a simple .where on Flags == 0 for quality.

Adds filter_sea_ice_quality and filter_sea_ice_swath to clear out a lot of unnecessary pixels.

I still need to confirm that both types of filtering are needed as the types of files I had were "clean" after filtering just by the quality flag (says Claude).

Code written by Claude with some edits by me.

CC @DougASchu

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@djhoese djhoese self-assigned this Nov 5, 2026
@djhoese
djhoese requested a review from mraspaud as a code owner November 5, 2026 12:59
@djhoese djhoese added enhancement code enhancements, features, improvements component:readers labels Nov 5, 2026
@codecov

codecov Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.43%. Comparing base (cca42cf) to head (93bb290).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3519    +/-   ##
========================================
  Coverage   96.42%   96.43%            
========================================
  Files         474      474            
  Lines       60784    60912   +128     
========================================
+ Hits        58610    58738   +128     
  Misses       2174     2174            
Flag Coverage Δ
behaviourtests 3.48% <0.00%> (-0.02%) ⬇️
unittests 96.51% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@djhoese djhoese changed the title Add two types of sea ice filtering to the 'amsr2_l2_gaasp' reader Add 'filter_sea_ice' flag to the 'amsr2_l2_gaasp' reader Nov 5, 2026
@djhoese
djhoese merged commit 2fe463c into pytroll:main Nov 5, 2026
16 of 18 checks passed
@djhoese
djhoese deleted the feat-gaasp-seaice-filters branch November 5, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:readers enhancement code enhancements, features, improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant