Skip to content

Add 'filter_sea_ice' flag to the 'amsr2_l2_gaasp' reader - #3519

Merged
djhoese merged 2 commits into
pytroll:mainfrom
djhoese:feat-gaasp-seaice-filters
Nov 5, 2026
Merged

djhoese merged 2 commits into
pytroll:mainfrom
djhoese:feat-gaasp-seaice-filters

Remove unnecessary filter_sea_ice_swath kwarg

93bb290
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Code Health Review (main) failed Nov 5, 2026 in 44s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Enforce advisory code health rules (2 files with Excess Number of Function Arguments)

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Enforce advisory code health rules Violations Code Health Impact
amsr2_l2_gaasp.py 1 advisory rule 10.00 → 9.69 Suppress
test_amsr2_l2_gaasp.py 1 advisory rule 10.00 → 9.69 Suppress

Quality Gate Profile: Clean Code Collective
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Excess Number of Function Arguments amsr2_l2_gaasp.py: GAASPFileHandler.init
  • Excess Number of Function Arguments test_amsr2_l2_gaasp.py: TestGAASPReader.test_sea_ice_filtering

Annotations

Check warning on line 84 in satpy/readers/amsr2_l2_gaasp.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Code Health Review (main)

❌ New issue: Excess Number of Function Arguments

GAASPFileHandler.__init__ has 5 arguments, max arguments = 4

This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.

Check warning on line 440 in satpy/tests/reader_tests/test_amsr2_l2_gaasp.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Code Health Review (main)

❌ New issue: Excess Number of Function Arguments

TestGAASPReader.test_sea_ice_filtering has 5 arguments, max arguments = 4

This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.