Repository navigation
Delete dead RCTBridge category implementations (#59315) - #59315
Open
christophpurrer wants to merge 3 commits into
Open
christophpurrer wants to merge 3 commits into
christophpurrer wants to merge 3 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D126574379. |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 21, 2026
Summary: Pull Request resolved: react#59315 Pull Request resolved: react#59263 RCTBridge is never instantiated, so its nine per-module category implementations never execute. Delete them and keep the proxy implementations plus all interface declarations, which callers still compile against. Changelog: [Internal] Differential Revision: D126574379
christophpurrer
force-pushed
the
export-D126574379
branch
from
October 21, 2026 17:19
24d3961 to
8a1e6c1
Compare
meta-codesync
Bot
changed the title
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 21, 2026
Summary: Pull Request resolved: react#59315 Pull Request resolved: react#59263 RCTBridge is never instantiated, so its nine per-module category implementations never execute. Delete them and keep the proxy implementations plus all interface declarations, which callers still compile against. Changelog: [Internal] Differential Revision: D126574379
christophpurrer
force-pushed
the
export-D126574379
branch
from
October 21, 2026 17:59
8a1e6c1 to
7ad1e3a
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 21, 2026
Summary: Pull Request resolved: react#59315 Pull Request resolved: react#59263 RCTBridge is never instantiated, so its nine per-module category implementations never execute. Delete them and keep the proxy implementations plus all interface declarations, which callers still compile against. Changelog: [Internal] Differential Revision: D126574379
christophpurrer
force-pushed
the
export-D126574379
branch
from
October 21, 2026 21:02
7ad1e3a to
d04d502
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 22, 2026
Summary: Pull Request resolved: react#59315 Pull Request resolved: react#59263 RCTBridge is never instantiated, so its nine per-module category implementations never execute. Delete them and keep the proxy implementations plus all interface declarations, which callers still compile against. Changelog: [Internal] Reviewed By: shwanton Differential Revision: D126574379
christophpurrer
force-pushed
the
export-D126574379
branch
from
October 22, 2026 19:39
d04d502 to
16bb9f4
Compare
Visual regression1 visual difference(s) at android: no capture ios
|
| Expected | Captured |
|---|---|
 |
 |
Summary: RCTProfile hooked bridge modules for systrace capture, driven only by the deleted legacy bridge. With all call sites migrated or removed, delete the header, implementation, trampolines, and remaining hooks in the display link, module methods, performance logger, and downstream systrace callers. Changelog: [iOS][Removed] - Remove deprecated RCTProfile systrace API Differential Revision: D126581734
Summary: Remove bridge declarations with zero callers: profiler flow state, test-only setup, module data lookup, profiling toggles, and the unimplemented TurboModule category. The proxy keeps its shims, so runtime behavior is unchanged. Changelog: [Internal] Differential Revision: D126592134
Summary: Pull Request resolved: react#59315 Pull Request resolved: react#59263 RCTBridge is never instantiated, so its nine per-module category implementations never execute. Delete them and keep the proxy implementations plus all interface declarations, which callers still compile against. Changelog: [Internal] Reviewed By: shwanton Differential Revision: D126574379
christophpurrer
force-pushed
the
export-D126574379
branch
from
October 23, 2026 04:03
16bb9f4 to
d4d15cb
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
RCTBridge is never instantiated, so its nine per-module category implementations never execute. Delete them and keep the proxy implementations plus all interface declarations, which callers still compile against.
Changelog:
[Internal]
Reviewed By: shwanton
Differential Revision: D126574379