Repository navigation
Remove dead RCTBridge imports from nine base files (#59320) - #59320
Open
christophpurrer wants to merge 7 commits into
Open
christophpurrer wants to merge 7 commits into
christophpurrer wants to merge 7 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D126580392. |
meta-codesync
Bot
changed the title
christophpurrer
force-pushed
the
export-D126580392
branch
from
October 21, 2026 23:28
f95e5b9 to
46644f3
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 21, 2026
Summary: Nine React Base implementation files imported the bridge headers without using any symbol they provide. RCTLog narrows to the module protocol header, which declares the registry interfaces it messages. Changelog: [Internal] Differential Revision: D126580392
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 21, 2026
Summary: Pull Request resolved: react#59320 Nine React Base implementation files imported the bridge headers without using any symbol they provide. RCTLog narrows to the module protocol header, which declares the registry interfaces it messages. Changelog: [Internal] Differential Revision: D126580392
christophpurrer
force-pushed
the
export-D126580392
branch
from
October 21, 2026 23:31
46644f3 to
f9df71f
Compare
cortinico
approved these changes
Oct 22, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Summary: Synthesize the injected launchOptions property and read getInitialURL state from it instead of self.bridge. Drops the last bridge read in this module along with its direct bridge header import. Changelog: [Internal] Reviewed By: shwanton Differential Revision: D126567470
Summary: Route JS-thread dispatch through the injected dispatchToJSThread block and read the injected performanceLogger. Delete the Views counter, which can only show zero since RCTViewRegistry exposes no enumeration, and reflow the HUD bar. Changelog: [iOS][Removed] - Remove the non-functional Views counter from the PerfMonitor HUD Reviewed By: shwanton Differential Revision: D126567926
Summary: Delete the always-false _isBridgeMode helper and fold its call sites to the bridgeless paths. Remove the no-op profiling bridge calls with their synchronize cascade, and simplify setExecutorClass to persist locally plus reload. Changelog: [Internal] Reviewed By: shwanton Differential Revision: D126574662
Summary: RCTComponentData always runs bridgeless, so delete the always-false isBridgeMode helper, merge the manager properties into one strong reference, and use the injected event dispatcher directly. Changelog: [Internal] Reviewed By: shwanton Differential Revision: D126575276
Summary: The interop layer only ever receives a bridge proxy, so delete the unused bridge ivar, init parameter, and bridge-only command paths. Keep the bridgeless flows and the proxy injection that legacy managers rely on. Changelog: [Internal] Reviewed By: shwanton Differential Revision: D126575534
Summary: RCTSampleLegacyModule on iOS and macOS stored a bridge that nothing reads. Delete the ivar and setter from both sample files. Changelog: [Internal] Reviewed By: shwanton Differential Revision: D126575656
Summary: Nine React Base implementation files imported the bridge headers without using any symbol they provide. RCTLog narrows to the module protocol header, which declares the registry interfaces it messages. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D126580392
christophpurrer
force-pushed
the
export-D126580392
branch
from
October 22, 2026 19:36
f9df71f to
129519d
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 22, 2026
Summary: Nine React Base implementation files imported the bridge headers without using any symbol they provide. RCTLog narrows to the module protocol header, which declares the registry interfaces it messages. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D126580392
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Nine React Base implementation files imported the bridge headers
without using any symbol they provide. RCTLog narrows to the module
protocol header, which declares the registry interfaces it messages.
Changelog:
[Internal]
Reviewed By: cortinico
Differential Revision: D126580392