Repository navigation
fix: keep card dealer cards below sticky page chrome - #235
Merged
Merged
Conversation
The table now isolates its stacking context, so card z-indices only order cards against each other and no longer draw over a fixed or sticky page header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Card Dealer cards drew over the site's fixed header when the page scrolled: each card carries a z-index (deck 0 to 51, hand 100+, pile 400+) and the table did not create its own stacking context, so those values competed with the header's.
The table is now
isolate, so card z-indices only order cards against each other.updatedAtand this week's changelog entry are updated.Verification
bun run check, card dealer a11y test