Skip to content

fix: keep card dealer cards below sticky page chrome #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
starc007 merged 1 commit into from
Oct 26, 2026
+15 −2
Merged

fix: keep card dealer cards below sticky page chrome #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion components/motion/card-dealer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,9 @@ export function CardDealer<T extends CardDealerCard>({
<section
ref={stageRef}
aria-label={ariaLabel}
className={cn("relative h-80 w-full touch-manipulation select-none", className)}
// isolate: card z-indices only order cards against each other, so the
// table never draws over sticky page chrome such as a header.
className={cn("relative isolate h-80 w-full touch-manipulation select-none", className)}
>
{/* One flat list, so a card changing zones keeps its element and flies
instead of remounting; zone by zone with the hand in fan order, so
Expand Down
11 changes: 11 additions & 0 deletions lib/changelog/entries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,17 @@ import type { ChangelogEntry } from "@/lib/changelog/types";
* accessibility and reduced-motion fixes. Leave out internal work.
*/
export const changelogEntries: ChangelogEntry[] = [
{
"date": "2026-10-26",
"title": "Card Dealer fixes",
"items": [
{
"type": "fixed",
"text": "Card Dealer cards stay inside their table and no longer draw over a sticky page header when you scroll.",
"component": "card-dealer"
}
]
},
{
"date": "2026-10-19",
"title": "A public changelog",
Expand Down
2 changes: 1 addition & 1 deletion lib/component-dates.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* maintenance should not refresh every component's public update date.
*/
const COMPONENT_DATES = {
"blocks/card-dealer": { publishedAt: "2026-10-24", updatedAt: "2026-10-24" },
"blocks/card-dealer": { publishedAt: "2026-10-24", updatedAt: "2026-10-26" },
"charts/sankey-chart": { publishedAt: "2026-10-22", updatedAt: "2026-10-22" },
"motion/timeline": { publishedAt: "2026-10-20", updatedAt: "2026-10-20" },
"charts/donut-chart": { publishedAt: "2026-10-12", updatedAt: "2026-10-18" },
Expand Down
Loading