Repository navigation
Fix millisecond precision in evaluation serverTime - #48
Open
paullianyang wants to merge 1 commit into
Open
paullianyang wants to merge 1 commit into
paullianyang wants to merge 1 commit into
Conversation
Author
|
for context the rounding is causing near exposure time metrics to show up prior to exposure rather than after. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve millisecond precision in
EvaluationDetails#server_timewhile keeping its string representation.The current expression converts
Time.nowto integer seconds before multiplying by 1,000, so every value ends in000. Convert to milliseconds before truncating instead, matching the timestamp-construction pattern already used byStatsigEvent.For example, a time of
1631638014.811999seconds currently produces"1631638014000"; this change produces"1631638014811".This changes evaluation metadata (
serverTime) only. It does not change the top-level eventtime, batching, deduplication, or export behavior, and does not claim to fix downstream exposure/event ordering.Tests
ruby -Ilib test/evaluation_details_precision_test.rb(1 test, 3 assertions).git diff --checkpass.bundle checkreports missing dependencies.