Skip to content

Fix millisecond precision in evaluation serverTime #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paullianyang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix millisecond precision in evaluation serverTime #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/evaluation_details.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def initialize(config_sync_time, init_time, reason)
@config_sync_time = config_sync_time
@init_time = init_time
@reason = reason
@server_time = (Time.now.to_i * 1000).to_s
@server_time = (Time.now.to_f * 1000).to_i.to_s
end

def self.unsupported(config_sync_time, init_time)
Expand Down
19 changes: 19 additions & 0 deletions test/evaluation_details_precision_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
require 'minitest/autorun'
require 'minitest/mock'
require_relative '../lib/evaluation_details'

class EvaluationDetailsPrecisionTest < Minitest::Test
def test_server_time_preserves_milliseconds_as_a_string
[
[0, '1631638014000'],
[811_999, '1631638014811'],
[999_999, '1631638014999'],
].each do |microseconds, expected|
Time.stub(:now, Time.at(1_631_638_014, microseconds)) do
details = Statsig::EvaluationDetails.new(1, 2, Statsig::EvaluationReason::NETWORK)

assert_equal(expected, details.server_time)
end
end
end
end