Skip to content

New variant - Malyan M300 3D Printer#828

Merged
fpistm merged 4 commits intostm32duino:masterfrom
papabricole:malyan-m300
Dec 13, 2019
Merged

New variant - Malyan M300 3D Printer#828
fpistm merged 4 commits intostm32duino:masterfrom
papabricole:malyan-m300

Conversation

@mojocorp
Copy link
Copy Markdown
Contributor

@mojocorp mojocorp commented Dec 11, 2019

This adds board support for Malyan M300 with STM32F070CBT MCU

@fpistm fpistm added the new variant Add support of new bard label Dec 11, 2019
@fpistm fpistm self-requested a review December 11, 2019 09:09
@mojocorp
New variant - Malyan M300 3D Printer
0884673 
The Malyan M300 is a mini delta printer from Malyansys:

  http://malyansys.com/product/m300/

and commercialized by Monoprice under the name:

  Monoprice MP Mini Delta 3D Printer

The mainboard is a pinout variation of the M200 V2.
@fpistm
Copy link
Copy Markdown
Member

fpistm commented Dec 11, 2019

Hi @mojocorp
Thanks for this variant.
I saw you made some force pushed.
Let me know when it is OK for review.
I will not be able to test so I will consider you test it 😉
I guess it is used with Marlin ?

@mojocorp
Copy link
Copy Markdown
Contributor Author

mojocorp commented Dec 11, 2019 •
edited
Loading

I just did some minor typo changes. I tested it with Marlin 2 and everything work, except saving the settings to flash. I don't know yet from where the problem is coming from and it will take me a lot of time. Since this variant is a variant from the M200 V2, I'm in contact with the original author. Maybe he can help me solve this issue.
Should I cancel this PR due to this know problem ?
If it's acceptable, I won't change this PR anymore and you can review it.

@fpistm
Copy link
Copy Markdown
Member

fpistm commented Dec 11, 2019

@mojocorp
Thanks for the feedback.
I will review the PR.
About EEPROM, no worry.

@fpistm
Merge MALYAN M200 and M300 F070CB
fac4966 
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm fpistm mentioned this pull request Dec 11, 2019
Merged
@mojocorp
Copy link
Copy Markdown
Contributor Author

mojocorp commented Dec 11, 2019

Thx for the improvements. I have to check that everything work as expected.
I'll tell you asap.

@mojocorp
Copy link
Copy Markdown
Contributor Author

mojocorp commented Dec 11, 2019

Everything work as expected!

@fpistm
Copy link
Copy Markdown
Member

fpistm commented Dec 11, 2019

Fine. As I said you can add the pins description if you want.

@mojocorp
Copy link
Copy Markdown
Contributor Author

mojocorp commented Dec 11, 2019 •
edited
Loading

Fine. As I said you can add the pins description if you want.

I just did it.
By the way, I've found an issue #297 about eeprom. It may be related to the problem I have with Marlin crashing when trying to save to flash.

@fpistm fpistm merged commit c2f9b45 into stm32duino:master Dec 13, 2019
@fpistm fpistm added this to the 1.8.0🎄 🎅 milestone Dec 13, 2019
@mojocorp
Copy link
Copy Markdown
Contributor Author

mojocorp commented Dec 13, 2019

It's certainly not the right place to comment but here it what happenend:
The M300 and M200 V2 variant are working with STM32 cores 1.7.0 but not with the current master 1.8.0-dev. The printer crashes almost immediately. I'm trying to bissect to detect which commit introduced the problem.

@fpistm
Copy link
Copy Markdown
Member

fpistm commented Dec 13, 2019

@mojocorp
Bad news, anyway I guess you use Marlin and so probably the Marlin needs update or you are not on the right branch of Marlin.
Maybe @LinoBarreca have some clue.

@LinoBarreca
Copy link
Copy Markdown
Contributor

LinoBarreca commented Dec 13, 2019

I wouldn't mind now since 1.8.0 hasn't been released yet and it isn't final. We will make the necessary modifications to Marlin when it's time to.

@fpistm
Copy link
Copy Markdown
Member

fpistm commented Dec 13, 2019

@LinoBarreca
I would just have your opinion about @mojocorp issue probably due to Marlin firmware misalignement,
Not the exact issue 😉

@LinoBarreca
Copy link
Copy Markdown
Contributor

LinoBarreca commented Dec 13, 2019

@fpistm Yeah, I understood what you meant. Fact is that me and @sjasonsmith did some hacks to make it work with 1.7.0 while making the PRs here.
when 1.8.0 comes out we will need to revisit (take away) the hacks we did....

..or did I misunderstand what you asked?

@fpistm
Copy link
Copy Markdown
Member

fpistm commented Dec 13, 2019

We are aligned ;)

@fpistm fpistm mentioned this pull request Dec 18, 2019
Merged
mojocorp added a commit to papabricole/Arduino_Core_STM32 that referenced this pull request Mar 9, 2020
@mojocorp
New variant - Malyan M300 3D Printer (stm32duino#828)
ff0a4b3
mojocorp added a commit to papabricole/Arduino_Core_STM32 that referenced this pull request Mar 28, 2020
@mojocorp
New variant - Malyan M300 3D Printer (stm32duino#828)
46e8769
mojocorp added a commit to papabricole/Arduino_Core_STM32 that referenced this pull request Mar 29, 2020
@mojocorp
New variant - Malyan M300 3D Printer (stm32duino#828)
e7dac85
mojocorp added a commit to papabricole/Arduino_Core_STM32 that referenced this pull request Mar 29, 2020
@mojocorp
New variant - Malyan M300 3D Printer (stm32duino#828)
d50f61e
mojocorp added a commit to papabricole/Arduino_Core_STM32 that referenced this pull request Mar 29, 2020
@mojocorp
New variant - Malyan M300 3D Printer (stm32duino#828)
880fdf5
mojocorp added a commit to papabricole/Arduino_Core_STM32 that referenced this pull request Mar 29, 2020
@mojocorp
New variant - Malyan M300 3D Printer (stm32duino#828)
eae0618
mojocorp added a commit to papabricole/Arduino_Core_STM32 that referenced this pull request Mar 29, 2020
@mojocorp
New variant - Malyan M300 3D Printer (stm32duino#828)
9434ef1
mojocorp added a commit to papabricole/Arduino_Core_STM32 that referenced this pull request Mar 29, 2020
@mojocorp
New variant - Malyan M300 3D Printer (stm32duino#828)
5a68f50
mojocorp added a commit to papabricole/Arduino_Core_STM32 that referenced this pull request Mar 29, 2020
@mojocorp
New variant - Malyan M300 3D Printer (stm32duino#828)
abe1f6e
mojocorp added a commit to papabricole/Arduino_Core_STM32 that referenced this pull request Mar 29, 2020
@mojocorp
New variant - Malyan M300 3D Printer (stm32duino#828)
1b657cf
@mojocorp
Copy link
Copy Markdown
Contributor Author

mojocorp commented Mar 29, 2020

I finally took the time to find the problem and it's due to the LTO option.
This commit in 1.8.0 introduce the problem:
fdc96bc Fix usage of weak functions instead of harden one
Since the Malyan M300 has only 128k flash, the LTO option is mandatory. Is there a workaround ?

@fpistm
Copy link
Copy Markdown
Member

fpistm commented Mar 30, 2020

@mojocorp
LTO option is provided "as is". They are several issue on arm gcc around this so I will not able to help on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fpistm fpistm fpistm approved these changes

Assignees

No one assigned

Labels

new variant Add support of new bard

Projects

None yet

Milestone

1.8.0🎄 🎅

Development

Successfully merging this pull request may close these issues.

3 participants

@mojocorp @fpistm @LinoBarreca