docs(push): fix stale TargetSize NOTE — no swap, [width, height]#153
Merged
Conversation
…] emit The TargetSize field NOTE still described the old #25/[H,W] behavior ("EMITTED as [height, width] ... buildImage does the swap"), which #147 (landed via #149) deliberately reverted. buildImage now emits [TargetSize[0], TargetSize[1]] = [width, height] with no swap — the order ingest.v1.json documents ("matches PIL.Image.size and what ImageResolutionValidator expects") and the order image_validator.py compares against verbatim. Rewrite the NOTE to state stored-and-emitted [width, height], no swap, and warn against re-introducing the swap (which failed every non-square dataset). Comment-only; rolls up under #145/#147. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
LukasWodka
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment-only fix. The
TargetSizefield NOTE ininternal/push/spec.gostill described the old #25/[H,W]behavior:That is wrong on both counts now.
buildImageemits[TargetSize[0], TargetSize[1]] = [width, height]with no swap — the state #147 (landed via #149) deliberately reverted to. The stale NOTE contradicted the inline comment right next to the emit and risked a future reader "re-fixing" it back to[H,W], which is exactly what failed every non-square dataset in-cluster.Ground truth (verified against
tracebloc/data-ingestors):ingest.v1.json: target_size is[width, height], "matches PIL.Image.size and what ImageResolutionValidator expects".image_validator.py:img.sizeis(width, height); comparesactual[0]↔expected[0](width),actual[1]↔expected[1](height).Rewrote the NOTE to state stored-and-emitted
[width, height], no swap, and warn against re-introducing the swap.Rolls up under #145/#147 — no new kanban ticket.
Note
Low Risk
Comment-only change to field documentation; no executable code or emitted spec behavior is modified.
Overview
Updates the
TargetSizefield NOTE onSpecArgsininternal/push/spec.goso it matches current behavior and the ingest contract.The old NOTE claimed values are stored as
[W, H]but emitted as[height, width]with a swap inbuildImage. That was outdated after #147:buildImageemits[width, height]with no dimension swap, aligned with ingest.v1 andImageResolutionValidator(PILimg.sizeorder). The revised NOTE documents stored-and-emitted[width, height], references the mistaken[H,W]swap from PR #22 that broke non-square datasets in-cluster, and warns against re-introducing a swap—consistent with the inline comment beside the emit inbuildImage.No runtime or spec-building logic changes—documentation only.
Reviewed by Cursor Bugbot for commit f26798a. Bugbot is set up for automated code reviews on this repo. Configure here.