Skip to content

docs(push): fix stale TargetSize NOTE — no swap, [width, height] #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saadqbal merged 1 commit into from
Jul 7, 2026
+8 −3
Merged

docs(push): fix stale TargetSize NOTE — no swap, [width, height] #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions internal/push/spec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,9 +144,14 @@ type SpecArgs struct {
// default apply. Populated by the CLI from --target-size or by
// auto-detecting the first image. (Image categories only.)
//
// NOTE: stored [W, H] here, but EMITTED as [height, width] by
// Build — that's the order the ingest.v1 schema documents and the
// ingestor reads. buildImage does the swap. (Bugbot, PR #22.)
// NOTE: stored [W, H] here AND emitted as [width, height] by
// buildImage — no swap. That's the order the ingest.v1 schema
// documents ("matches PIL.Image.size and what
// ImageResolutionValidator expects") and the order the validator
// compares against verbatim (PIL's img.size is (W, H)). An earlier
// [H,W] revision (PR #22 review note) was mistaken and made every
// non-square dataset fail in-cluster; #147 reverted it. Do not
// re-introduce a swap. (See the inline comment in buildImage.)
TargetSize []int

// Schema is the column→SQL-type map for tabular / time-series
Expand Down
Loading