Repository navigation
A big diagram in the PDF keeps readable text - #16
Merged
Merged
Conversation
…ge, as a float), not 65% The empty page after a tall diagram was fixed by capping figures at 65% of the page, which squeezed a big architecture diagram until its words were about 6 pt (the end-to-end test "on the PDF page a big diagram's words are not tiny" fails). What avoids the empty page is that a tall figure floats; the cap only has to leave room for its caption, so it is 85% of the text height again (a little less than the 90% from before). A figure that fills 80% of a page or more gets a page of its own, below that it shares the page with text. The other four sample pictures come out pixel for pixel the same. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#13 capped figures at 65% of the page to stop an empty page after a tall diagram. The full end-to-end run (which I should have run before merging #13) shows it squeezes a big architecture diagram: its words come out under 7 pt and
diagram-fit.spec.ts"on the PDF page a big diagram's words are not tiny" fails.What
What avoids the empty page is that a tall figure floats, not the cap. The cap only has to leave room for the caption, so it is 85% of the text height (it was 90% before #13). A figure filling 80% of a page or more gets a page of its own; below that it shares the page with text. The empty-page regression test still passes,
diagram-fitpasses, and the five sample pictures regenerate pixel for pixel the same.🤖 Generated with Claude Code