Repository navigation
test(desktop): the PDF quiet-limit test no longer fails when the machine is busy - #2
Merged
Merged
Conversation
…s when the machine is busy The stand-in engine had to print its first line within 1 s, which a slow start of the script under the parallel test run sometimes missed (one failure in about six full runs). The limit is now 2 s with an engine that prints for about 5 s, so the test still shows that an engine which keeps printing runs longer than the limit. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
triggeredcode
force-pushed
the
fix-pdf-timing-test
branch
from
October 11, 2026 21:21
c976a86 to
ccfc277
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
electron/pdf.test.ts› lets an engine that keeps downloading run longer than the quiet limit failed once in about six full unit runs: the stand-in engine script had to print its first line within the 1 s quiet limit, and a slow start of the script while the whole suite runs in parallel can exceed that (it surfaced asexpected false to be trueonr.ok).The limit is now 2 s (five times the 0.4 s print interval) with an engine that prints for about 5 s, so the test still proves what it is for: an engine that keeps printing is allowed to run longer than the quiet limit. The other test that shares the 6-file script is unchanged.
Checked: the file 3 times alone and the full unit suite twice, all passing.
🤖 Generated with Claude Code