Skip to content

test(desktop): the PDF quiet-limit test no longer fails when the machine is busy #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
triggeredcode merged 1 commit into from
Oct 11, 2026
Merged

test(desktop): the PDF quiet-limit test no longer fails when the machine is busy #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions apps/desktop/electron/pdf.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,12 +140,16 @@ describe("the first run, which downloads the typesetting files", () => {
}, 30_000);

it("lets an engine that keeps downloading run longer than the quiet limit", async () => {
const t = await script(downloads);
const { c } = await compiler(t, stubConvert, { idleMs: 1_000 });
// Prints every 0.4 s for about 5 s. The quiet limit is 2 s, five times the interval, so a slow start of the script on a
// busy machine (the whole suite runs in parallel) does not trip it.
const t = await script(
'for i in 1 2 3 4 5 6 7 8 9 10 11 12; do echo "note: downloading f$i.sty"; sleep 0.4; done\necho "%PDF-1.5" > main.pdf',
);
const { c } = await compiler(t, stubConvert, { idleMs: 2_000 });
const started = Date.now();
const r = await c.compile(req("page-slow"));
expect(r.ok).toBe(true);
expect(Date.now() - started).toBeGreaterThan(1_800); // longer than the quiet limit, because it kept printing
expect(Date.now() - started).toBeGreaterThan(2_800); // longer than the quiet limit, because it kept printing
}, 30_000);

it("stops an engine that runs for too long, however much it prints", async () => {
Expand Down
Loading