Skip to content

Main uses of canComplexCarryFlashSuit#2259

Merged
blkerby merged 5 commits intovg-json-data:masterfrom
blkerby:complex-flash-uses
Aug 25, 2025
Merged

Main uses of canComplexCarryFlashSuit#2259
blkerby merged 5 commits intovg-json-data:masterfrom
blkerby:complex-flash-uses

Conversation

@blkerby
Copy link
Copy Markdown
Contributor

@blkerby blkerby commented Aug 24, 2025

This builds on PR #2258 , which should be merged first.

Comment thread tech.json Outdated
{"noFlashSuit": {}},
{"and": [
"HiJump",
"canPreciseGrappleJump",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it mean to be self-dependant?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, yeah I think that would be a problem. We could avoid the circular dependency by using {"tech": "canPreciseGrappleJump"}, but I think it may be better to switch to using helpers instead of trying to cram all this into the tech otherRequires. Using helpers should allow cutting down on the amount of redundant requirements too

Copy link
Copy Markdown
Contributor Author

@blkerby blkerby Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess a simpler solution is to just drop the canPreciseGrappleJump and canTrickyGrappleJump requirements here. In terms of difficulty placement it's already covered by the canComplexCarryFlashSuit and canTrickyCarryFlashSuit.

@blkerby blkerby force-pushed the complex-flash-uses branch from 0cdb2db to 82da07a Compare August 25, 2025 14:39
kjbranch
kjbranch previously approved these changes Aug 25, 2025
Copy link
Copy Markdown
Contributor

@kjbranch kjbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I think it would be good if we had another helper, like h_ComplexCarryFlashSuit, defined as canComplexCarryFlashSuit or noFlashSuit. And then we could prevent canComplexCarryFlashSuit from being used in strats (similar to how we don't use SpringBall and instead use h_useSpringBall.)

Comment thread helpers.json Outdated
osse101
osse101 previously approved these changes Aug 25, 2025
Co-authored-by: kjbranch <61815121+kjbranch@users.noreply.github.com>
@blkerby blkerby dismissed stale reviews from osse101 and kjbranch via 21129da August 25, 2025 21:01
@blkerby blkerby merged commit 720c22f into vg-json-data:master Aug 25, 2025
1 check passed
@blkerby blkerby deleted the complex-flash-uses branch February 15, 2026 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants