-
Notifications
You must be signed in to change notification settings - Fork 19
Red Brinstar check flash suits pt. 1 #2284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -116,7 +116,8 @@ | |
| "length": 4, | ||
| "openEnd": 1 | ||
| } | ||
| } | ||
| }, | ||
| "flashSuitChecked": true | ||
| }, | ||
| { | ||
| "id": 2, | ||
|
|
@@ -179,7 +180,8 @@ | |
| "openEnd": 1 | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "flashSuitChecked": true | ||
| }, | ||
| { | ||
| "id": 4, | ||
|
|
@@ -204,7 +206,8 @@ | |
| "openEnd": 1 | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "flashSuitChecked": true | ||
| }, | ||
| { | ||
| "id": 5, | ||
|
|
@@ -230,7 +233,8 @@ | |
| }, | ||
| "movementType": "uncontrolled" | ||
| } | ||
| } | ||
| }, | ||
| "flashSuitChecked": true | ||
| }, | ||
| { | ||
| "id": 6, | ||
|
|
@@ -256,7 +260,8 @@ | |
| }, | ||
| "movementType": "controlled" | ||
| } | ||
| } | ||
| }, | ||
| "flashSuitChecked": true | ||
| }, | ||
| { | ||
| "id": 7, | ||
|
|
@@ -280,6 +285,7 @@ | |
| "movementType": "controlled" | ||
| } | ||
| }, | ||
| "flashSuitChecked": true, | ||
| "note": "At high speed, it is possible to avoid Boyon damage." | ||
| }, | ||
| { | ||
|
|
@@ -300,7 +306,8 @@ | |
| "openEnd": 1 | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "flashSuitChecked": true | ||
| }, | ||
| { | ||
| "id": 28, | ||
|
|
@@ -314,7 +321,8 @@ | |
| ], | ||
| "clearsObstacles": ["A"], | ||
| "resetsObstacles": ["B"], | ||
| "farmCycleDrops": [{"enemy": "Boyon", "count": 4}] | ||
| "farmCycleDrops": [{"enemy": "Boyon", "count": 4}], | ||
| "flashSuitChecked": true | ||
| }, | ||
| { | ||
| "id": 9, | ||
|
|
@@ -342,7 +350,8 @@ | |
| "ceilingPositions": [] | ||
| } | ||
| }, | ||
| "bypassesDoorShell": "free" | ||
| "bypassesDoorShell": "free", | ||
| "flashSuitChecked": true | ||
| }, | ||
| { | ||
| "id": 10, | ||
|
|
@@ -358,10 +367,6 @@ | |
| "h_useSpringBall" | ||
| ]}, | ||
| "can4HighMidAirMorph", | ||
| {"and": [ | ||
| "SpaceJump", | ||
| "canCarefulJump" | ||
| ]}, | ||
| {"and": [ | ||
| "SpaceJump", | ||
| "ScrewAttack" | ||
|
|
@@ -371,7 +376,8 @@ | |
| "canCarefulJump" | ||
| ]} | ||
| ]} | ||
| ] | ||
| ], | ||
| "flashSuitChecked": true | ||
| }, | ||
| { | ||
| "id": 11, | ||
|
|
@@ -385,7 +391,8 @@ | |
| }, | ||
| "requires": [ | ||
| "canCarefulJump" | ||
| ] | ||
| ], | ||
| "flashSuitChecked": true | ||
| }, | ||
| { | ||
| "id": 12, | ||
|
|
@@ -407,7 +414,8 @@ | |
| ]} | ||
| ]} | ||
| ], | ||
| "clearsObstacles": ["A"] | ||
| "clearsObstacles": ["A"], | ||
| "flashSuitChecked": true | ||
| }, | ||
| { | ||
| "id": 13, | ||
|
|
@@ -417,15 +425,16 @@ | |
| {"or": [ | ||
| {"enemyDamage": {"enemy": "Boyon", "type": "contact", "hits": 2}}, | ||
| {"and": [ | ||
| "canCarefulJump", | ||
| "canDodgeWhileShooting", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This wasn't changed on the return strat |
||
| {"enemyDamage": {"enemy": "Boyon", "type": "contact", "hits": 1}} | ||
| ]}, | ||
| {"and": [ | ||
| "canHorizontalDamageBoost", | ||
| {"enemyDamage": {"enemy": "Boyon", "type": "contact", "hits": 1}} | ||
| ]} | ||
| ]} | ||
| ] | ||
| ], | ||
| "flashSuitChecked": true | ||
| }, | ||
| { | ||
| "id": 14, | ||
|
|
@@ -583,7 +592,8 @@ | |
| "blockPositions": [[5, 3], [7, 2]] | ||
| } | ||
| }, | ||
| "requires": [] | ||
| "requires": [], | ||
| "flashSuitChecked": true | ||
| }, | ||
| { | ||
| "id": 19, | ||
|
|
@@ -599,10 +609,6 @@ | |
| "h_useSpringBall" | ||
| ]}, | ||
| "can4HighMidAirMorph", | ||
| {"and": [ | ||
| "SpaceJump", | ||
| "canCarefulJump" | ||
| ]}, | ||
| {"and": [ | ||
| "SpaceJump", | ||
| "ScrewAttack" | ||
|
|
@@ -612,7 +618,8 @@ | |
| "canCarefulJump" | ||
| ]} | ||
| ]} | ||
| ] | ||
| ], | ||
| "flashSuitChecked": true | ||
| }, | ||
| { | ||
| "id": 20, | ||
|
|
@@ -634,7 +641,8 @@ | |
| ]} | ||
| ]} | ||
| ], | ||
| "clearsObstacles": ["A"] | ||
| "clearsObstacles": ["A"], | ||
| "flashSuitChecked": true | ||
| }, | ||
| { | ||
| "id": 21, | ||
|
|
@@ -652,7 +660,8 @@ | |
| {"enemyDamage": {"enemy": "Boyon", "type": "contact", "hits": 1}} | ||
| ]} | ||
| ]} | ||
| ] | ||
| ], | ||
| "flashSuitChecked": true | ||
| }, | ||
| { | ||
| "id": 22, | ||
|
|
@@ -664,12 +673,13 @@ | |
| "h_usePowerBomb" | ||
| ]} | ||
| ], | ||
| "clearsObstacles": ["B"] | ||
| "clearsObstacles": ["B"], | ||
| "flashSuitChecked": true | ||
| }, | ||
| { | ||
| "id": 23, | ||
| "link": [2, 3], | ||
| "name": "Kill Boyons and PB Blocks", | ||
| "name": "Kill Boyons and Power Bomb Blocks", | ||
| "requires": [ | ||
| {"obstaclesNotCleared": ["A"]}, | ||
| {"enemyKill": { | ||
|
|
@@ -678,7 +688,8 @@ | |
| }} | ||
| ], | ||
| "clearsObstacles": ["A", "B"], | ||
| "note": "Place the PB on the block next to the leftmost Boyon, in order to double hit all Boyons and break the PB blocks." | ||
| "flashSuitChecked": true, | ||
| "note": "Place the Power Bomb on the block next to the leftmost Boyon, in order to double hit all Boyons and break the PB blocks." | ||
| }, | ||
| { | ||
| "id": 24, | ||
|
|
@@ -690,7 +701,8 @@ | |
| "h_usePowerBomb" | ||
| ]} | ||
| ], | ||
| "clearsObstacles": ["B"] | ||
| "clearsObstacles": ["B"], | ||
| "flashSuitChecked": true | ||
| } | ||
| ], | ||
| "notables": [], | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is easier with spacejump and that it wasn't represented correctly at carefuljump.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it feels pretty hard to do with space. I think it would be fine to have them both in Hard, or both in VH, or we can just have Space in Hard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think people wouldn't be happy naked boyon dodging in hard.
Door to item with space did feel pretty hard. Item to door was slightly better.
So for Space to help I think we want run speed from entering with run speed or from behind the PB wall. But I also think it would be just as good to add space to hard to ease the transition to the dodge strat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The space jump makes sense to me now. I don't think I was gaining dash speed. Split the strat and added a note