[devswha]

Wave C1 of the per-agent module split. The plan is .omo/plans/agent-modules-split.md in the maintainer's workspace, and plan-reviewer approved it. It follows P1a (#1755).

This wave moves the Claude transcript parser out of server/conversation.ts into a new leaf module, server/claude-transcript.ts. conversation.ts keeps:

• every cache and both forget* functions;
• the paging core and the transcript resolvers;
• the three functions tests spy on (paneTranscript, readCommandTranscript, paneProcessRoots).

It re-exports the parser's public names, so no importer changes.

What changes

• Moved verbatim, with their doc comments: about 420 lines. That covers isCommandEntry through parseClaudeTranscript:
  • the local-command and notice helpers, stripTerminalControls and unwrapPastes;
  • TranscriptEntry, claudeResultText, IMAGE_TYPES;
  • the parser state, createClaudeTranscriptParser, claudeTranscriptParser and parseClaudeTranscript.
• New export keywords: four names gain one, because conversation.ts still uses them: isCommandEntry, claudeResultText, IMAGE_TYPES and the type TranscriptEntry.
• Re-exports: conversation.ts re-exports parseClaudeTranscript, createClaudeTranscriptParser and unwrapPastes. Its other imports narrow to what it still uses.
• Not moved: the parser holds no module state (its state lives in closures), so no cache changes owner.

Checks

• --color-moved: git diff --color-moved=plain --color-moved-ws=allow-indentation-change origin/main...HEAD -- server shows 831 lines as moved. The other 19 lines are the new module's imports, conversation.ts's narrowed imports, the re-export, and the four export keywords.

• No import cycle: bun <plan>/no-path.ts server/claude-transcript.ts server/conversation.ts server/prompt.ts exits 0. It follows value imports through every file, and the new module never reaches conversation.ts or prompt.ts.

• Spied names stay put: paneTranscript, readCommandTranscript and paneProcessRoots are still declared in conversation.ts.

• No new herdr call: server/claude-transcript.ts has no herdrRpc call (server/conventions.test.ts forbids new ones).

• Typecheck: bun run typecheck passes.

• Unit tests: 212 pass, 0 fail, from:

  HERDR_TEST_MODE=unit bun test server/chat-history.test.ts server/claude-incremental.test.ts server/claude-turn-boundaries.test.ts server/skill-activity.test.ts server/conversation.test.ts server/native-incremental.test.ts server/large-history-agents.test.ts server/outcome-transcript*.test.ts

• bun run check fast: passes (unit 6251 pass, 0 fail, 13 skip in 443 files, 8 at a time, 73.4s)

• Integration lane: CI runs claude-session.contract and conversation-push.contract.

Outside PRs that touch the same files

No other maintainer PR touches these files. Three outside contributors' PRs touch server/conversation.ts. I checked each against this branch with git merge-tree:

• feat(chat): read native Muse Code conversations #1706 still merges cleanly.
• feat(chat): read native Copilot CLI transcripts #1652 conflicts only in two import blocks at the top of conversation.ts: the ../shared/protocol.ts type import, and the line after ./tool-output.ts where it adds its Copilot imports. Its code changes do not touch the moved parser.
• feat(chat): read a droid pane's own session as its conversation #1442 already conflicts with main in conversation.ts, and needs a rebase either way.

Move-only: moved declarations plus imports, re-exports and four export keywords. No changelog fragment: users see no change.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Source mode: Auto
• Repository: devswha/ovis
• Branch: refactor/claude-transcript-module
• File: .coderabbit.yaml
• Commit: 3ac1999
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 633f559c-00c3-4030-9ade-d205c5b88d78

📥 Commits

Reviewing files that changed from the base of the PR and between e590552 and 3ac1999.

📒 Files selected for processing: 2

• server/claude-transcript.ts
• server/conversation.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

📝 Summary

Summary by CodeRabbit

• New Features
  • Claude conversation transcripts now support both live updates and complete transcript reads.
  • Conversation history includes prompts, responses, tool activity, images, and notifications, while filtering command and bookkeeping entries.
  • Invalid transcript lines are skipped, and complete reads can be limited to the most recent turns.

The pull request moves Claude transcript parsing from server/conversation.ts into server/claude-transcript.ts. The parser folds transcript entries into conversation turns, supports incremental snapshots and one-shot parsing, and is re-exported from the existing module.

Changes: Claude transcript parsing

Layer / File(s)	Summary
Transcript entry normalization server/claude-transcript.ts	Defines transcript data and parser options. Filters command entries, unwraps pasted content, and processes terminal output and notices.
Turn state and event folding server/claude-transcript.ts	Tracks parser state and folds task notifications, peer notices, context clears, prompts, and informational notices into turns.
User and assistant event handling server/claude-transcript.ts	Folds user content, tool results, supported images, assistant text, thinking, and tool calls into turns.
Incremental parsing and module integration server/claude-transcript.ts, server/conversation.ts	Adds JSONL writing, snapshots, and one-shot parsing. Replaces the local implementation with imports and re-exports from the new module.

Priority: ⬇️ Low

Estimated code review effort: 4 (Complex) | ~40 minutes

Change: Refactor

Suggested reviewers: yoonwoo-ha

Merge Risk: ⚪ Minimal · up to 3ac19

This is a behavior-preserving refactor that moves the Claude transcript parser into its own module while keeping the existing import paths. No concrete risk was found, and it looks safe to merge after normal checks.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 69.23% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 13 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title "refactor(server): move the Claude transcript parser into its own module" matches the main change. The PR moves the parser from server/conversation.ts into the new server/claude-transcript.t…
Description check		The description follows the repository template. It has a Change section that explains the move, the re-exports, the four new export keywords, and the reason no behavior changes. It has a Validation s…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title "refactor(server): move the Claude transcript parser into its own module" matches the main change. The PR moves the parser from server/conversation.ts into the new server/claude-transcript.ts, and the objectives confirm this. The title is specific and uses the conventional refactor prefix.

Full details: Description check

Explanation

The description follows the repository template. It has a Change section that explains the move, the re-exports, the four new export keywords, and the reason no behavior changes. It has a Validation section that lists typecheck, unit tests, the fast check lane, the no-import-cycle check, and the CI contract lanes. The template asks for contract-test coverage on HTTP/WS changes. This PR makes no HTTP/WS change, and the author lists the contract lanes that CI runs. The description also cites the changelog rule and explains why no changelog fragment is included.

✨ Finishing Touches: 💡 1

📝 Generate docstrings: 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[devswha]

Merge pass: this is a move-only PR (per-agent split, wave C1). As AGENTS.md allows, it is merged on its checks without waiting for a CodeRabbit review.

• Pure move. Comparing removed and added lines, the only differences are:
  • imports;
  • four export keywords (isCommandEntry, claudeResultText, IMAGE_TYPES, TranscriptEntry);
  • the one re-export line.
• Gate review. A gate reviewer on a different model than the author's confirmed:
  • the 416-line parser moved in order, identical apart from those keywords;
  • re-exports, caches, forget*, paging, resolvers and the spied functions all stay in conversation.ts;
  • no import cycle;
  • no operational cache moved. IMAGE_TYPES is a constant Set.
• Tests. 193 targeted tests, typecheck and 45 convention tests pass.
• Overlap. Outside contributors' feat(chat): read a droid pane's own session as its conversation #1442, feat(chat): read native Copilot CLI transcripts #1652 and feat(chat): read native Muse Code conversations #1706 also touch server/conversation.ts. At most they need a rebase.

All required checks are green and no review thread is open.