Skip to content

fix: fix html-validation error #1658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
eryue0220 wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

fix: fix html-validation error #1658

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
65fcacd
fix html validation
eryue0220 Feb 26, 2026
573e631
Merge branch 'main' into fix/fix-html-validation-error
eryue0220 Feb 26, 2026
ef5755c
add transition
eryue0220 Feb 26, 2026
fabad0f
fix ut
eryue0220 Feb 26, 2026
0006681
fix error
eryue0220 Apr 17, 2026
3929351
fix conflict
eryue0220 Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/Package/ManagerSelect.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ function handleKeydown(event: KeyboardEvent) {
:aria-expanded="isOpen"
aria-haspopup="listbox"
:aria-label="$t('package.get_started.pm_label')"
:aria-controls="listboxId"
:aria-controls="isOpen ? listboxId : undefined"
@click="toggle"
@keydown="handleKeydown"
>
Expand Down
136 changes: 67 additions & 69 deletions app/components/ReadmeTocDropdown.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,85 +166,83 @@ function handleKeydown(event: KeyboardEvent) {
</ButtonBase>

<Teleport to="body">
<Transition
:enter-active-class="prefersReducedMotion ? '' : 'transition-opacity duration-150'"
:enter-from-class="prefersReducedMotion ? '' : 'opacity-0'"
enter-to-class="opacity-100"
:leave-active-class="prefersReducedMotion ? '' : 'transition-opacity duration-100'"
leave-from-class="opacity-100"
:leave-to-class="prefersReducedMotion ? '' : 'opacity-0'"
<div
:id="listboxId"
ref="listRef"
role="listbox"
:aria-hidden="!isOpen"
:aria-activedescendant="
isOpen && highlightedIndex >= 0 ? `${listboxId}-${toc[highlightedIndex]?.id}` : undefined
"
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
:aria-label="$t('package.readme.toc_title')"
:style="
isOpen
? getDropdownStyle()
: { visibility: 'hidden', position: 'fixed', pointerEvents: 'none' }
"
:class="[
'fixed bg-bg-subtle border border-border rounded-md shadow-lg z-50 max-h-80 overflow-y-auto w-56 overscroll-contain',
!isOpen ? 'opacity-0' : prefersReducedMotion ? '' : 'transition-opacity duration-150',
]"
>
<div
v-if="isOpen"
:id="listboxId"
ref="listRef"
role="listbox"
:aria-activedescendant="
highlightedIndex >= 0 ? `${listboxId}-${toc[highlightedIndex]?.id}` : undefined
"
:aria-label="$t('package.readme.toc_title')"
:style="getDropdownStyle()"
class="fixed bg-bg-subtle border border-border rounded-md shadow-lg z-50 max-h-80 overflow-y-auto w-56 overscroll-contain"
>
<template v-for="node in tocTree" :key="node.id">
<template v-for="node in tocTree" :key="node.id">
<NuxtLink
:id="`${listboxId}-${node.id}`"
:to="`#${node.id}`"
role="option"
:aria-selected="activeId === node.id"
class="flex items-center gap-2 px-3 py-1.5 text-sm cursor-pointer transition-colors duration-150"
:class="[
activeId === node.id ? 'text-fg font-medium' : 'text-fg-muted',
highlightedIndex === getIndex(node.id) ? 'bg-bg-elevated' : 'hover:bg-bg-elevated',
]"
dir="auto"
@click="select()"
@mouseenter="highlightedIndex = getIndex(node.id)"
>
<span class="truncate">{{ node.text }}</span>
</NuxtLink>

<template v-for="child in node.children" :key="child.id">
<NuxtLink
:id="`${listboxId}-${node.id}`"
:to="`#${node.id}`"
:id="`${listboxId}-${child.id}`"
:to="`#${child.id}`"
role="option"
:aria-selected="activeId === node.id"
class="flex items-center gap-2 px-3 py-1.5 text-sm cursor-pointer transition-colors duration-150"
:aria-selected="activeId === child.id"
class="flex items-center gap-2 px-3 py-1.5 ps-6 text-sm cursor-pointer transition-colors duration-150"
:class="[
activeId === node.id ? 'text-fg font-medium' : 'text-fg-muted',
highlightedIndex === getIndex(node.id) ? 'bg-bg-elevated' : 'hover:bg-bg-elevated',
activeId === child.id ? 'text-fg font-medium' : 'text-fg-subtle',
highlightedIndex === getIndex(child.id) ? 'bg-bg-elevated' : 'hover:bg-bg-elevated',
]"
dir="auto"
@click="select()"
@mouseenter="highlightedIndex = getIndex(node.id)"
@mouseenter="highlightedIndex = getIndex(child.id)"
>
<span class="truncate">{{ node.text }}</span>
<span class="truncate">{{ child.text }}</span>
</NuxtLink>

<template v-for="child in node.children" :key="child.id">
<NuxtLink
:id="`${listboxId}-${child.id}`"
:to="`#${child.id}`"
role="option"
:aria-selected="activeId === child.id"
class="flex items-center gap-2 px-3 py-1.5 ps-6 text-sm cursor-pointer transition-colors duration-150"
:class="[
activeId === child.id ? 'text-fg font-medium' : 'text-fg-subtle',
highlightedIndex === getIndex(child.id) ? 'bg-bg-elevated' : 'hover:bg-bg-elevated',
]"
dir="auto"
@click="select()"
@mouseenter="highlightedIndex = getIndex(child.id)"
>
<span class="truncate">{{ child.text }}</span>
</NuxtLink>

<NuxtLink
v-for="grandchild in child.children"
:id="`${listboxId}-${grandchild.id}`"
:to="`#${grandchild.id}`"
:key="grandchild.id"
role="option"
:aria-selected="activeId === grandchild.id"
class="flex items-center gap-2 px-3 py-1.5 ps-9 text-sm cursor-pointer transition-colors duration-150"
:class="[
activeId === grandchild.id ? 'text-fg font-medium' : 'text-fg-subtle',
highlightedIndex === getIndex(grandchild.id)
? 'bg-bg-elevated'
: 'hover:bg-bg-elevated',
]"
dir="auto"
@click="select()"
@mouseenter="highlightedIndex = getIndex(grandchild.id)"
>
<span class="truncate">{{ grandchild.text }}</span>
</NuxtLink>
</template>
<NuxtLink
v-for="grandchild in child.children"
:id="`${listboxId}-${grandchild.id}`"
:to="`#${grandchild.id}`"
:key="grandchild.id"
role="option"
:aria-selected="activeId === grandchild.id"
class="flex items-center gap-2 px-3 py-1.5 ps-9 text-sm cursor-pointer transition-colors duration-150"
:class="[
grandchild.id === activeId ? 'text-fg font-medium' : 'text-fg-subtle',
highlightedIndex === getIndex(grandchild.id)
? 'bg-bg-elevated'
: 'hover:bg-bg-elevated',
]"
dir="auto"
@click="select()"
@mouseenter="highlightedIndex = getIndex(grandchild.id)"
>
<span class="truncate">{{ grandchild.text }}</span>
</NuxtLink>
</template>
</div>
</Transition>
</template>
</div>
</Teleport>
</template>
5 changes: 4 additions & 1 deletion nuxt.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,10 @@ export default defineNuxtConfig({
htmlValidator: {
enabled: !isCI || (provider !== 'vercel' && !!process.env.VALIDATE_HTML),
options: {
rules: { 'meta-refresh': 'off' },
rules: {
'meta-refresh': 'off',
'prefer-native-element': ['error', { exclude: ['listbox'] }],
Copy link
Copy Markdown
Member

@serhalp serhalp Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Per https://discord.com/channels/1464542801676206113/1464926468751753269/1471511992434163844, I think if anything we'd want exactly the opposite (include), wouldn't we? As is this would suppress warnings about role=listbox, which we do want to eliminate.

Copy link
Copy Markdown
Contributor Author

@eryue0220 eryue0220 Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the goal is to rewrite those components which their attribute is role=listbox, right?

},
},
failOnError: true,
},
Expand Down
Loading