Skip to content

fix(i18n): add missing fr entries, tweaks#361

Merged
danielroe merged 5 commits intonpmx-dev:mainfrom
WarningImHack3r:baguette
Jan 29, 2026
Merged

fix(i18n): add missing fr entries, tweaks#361
danielroe merged 5 commits intonpmx-dev:mainfrom
WarningImHack3r:baguette

Conversation

@WarningImHack3r
Copy link
Copy Markdown
Contributor

@WarningImHack3r WarningImHack3r commented Jan 29, 2026

  • add missing French entries
  • linkify the path to the locales directory in CONTRIBUTING.md
  • tweak CSS for longer titles in the /about

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 29, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Jan 29, 2026 10:53pm
npmx.dev Ready Ready Preview, Comment Jan 29, 2026 10:53pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
npmx-lunaria Ignored Ignored Jan 29, 2026 10:53pm

Request Review

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 29, 2026 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/fr-FR.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

serhalp
serhalp approved these changes Jan 29, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@serhalp serhalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMoi! Merci!

Comment thread i18n/locales/fr-FR.json
Comment on lines +73 to +79
"i18n": {
"missing_keys": "{count} traduction manquante | {count} traductions manquantes",
"copy_keys": "Copier les noms",
"show_more_keys": "Afficher {count} de plus...",
"contribute_hint": "Aidez à améliorer cette traduction en ajoutant les entrées manquantes.",
"edit_on_github": "Modifier sur GitHub",
"view_guide": "Guide de traduction"
Copy link
Copy Markdown
Member

@serhalp serhalp Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un peu ironique 😄

Copy link
Copy Markdown
Contributor Author

@WarningImHack3r WarningImHack3r Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment ça ?

Comment thread i18n/locales/fr-FR.json
"copy": "copier",
"copied": "copié !",
"skip_link": "Passer au contenu principal",
"close_modal": "Fermer la fenêtre",
Copy link
Copy Markdown
Member

@serhalp serhalp Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est-ce qu'il y a un mot plus précis pour "modal" en français? 🤔

Copy link
Copy Markdown
Contributor Author

@WarningImHack3r WarningImHack3r Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui, sûrement, mais j’ai voulu garder la traduction que @jycouet avait faite pour d’autres modales

Copy link
Copy Markdown
Contributor

@jycouet jycouet Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comme beaucoup de traduction, l'IA a fait une bonne partie ☺️. J'ai fait une passe complète, mais j'suis sûr qu'il y a des améliorations possibles 👍

N'hésitez pas.
On peut se ping sur le sujet

@danielroe danielroe enabled auto-merge January 29, 2026 22:59
@danielroe danielroe added this pull request to the merge queue Jan 29, 2026
Merged via the queue into npmx-dev:main with commit e4181fc Jan 29, 2026
13 checks passed
@WarningImHack3r WarningImHack3r deleted the baguette branch January 30, 2026 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhalp serhalp serhalp approved these changes

@danielroe danielroe danielroe approved these changes

+1 more reviewer

@jycouet jycouet jycouet left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@WarningImHack3r @serhalp @jycouet @danielroe